|
Description
Martin Renvoize (ashimema)
2022-10-21 14:04:39 UTC
Created attachment 142398 [details] [review] Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. I think this is a good improvement, but I am in doubt about this heading: Total items: 2 It doesn't feel like a heading to me, but more like it should appear in the line below one. Maybe the heading could be: Items in collection ? Created attachment 142504 [details] [review] Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. Created attachment 142505 [details] [review] Bug 31911: (follow-up) Rename second level heading This patch, as suggested, renames the second level heading to 'Items in collection' and move the 'Total items: {count}' into a paragraph. Created attachment 142558 [details] [review] Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. Signed-off-by: David Nind <david@davidnind.com> Created attachment 142559 [details] [review] Bug 31911: (follow-up) Rename second level heading This patch, as suggested, renames the second level heading to 'Items in collection' and move the 'Total items: {count}' into a paragraph. Signed-off-by: David Nind <david@davidnind.com> Created attachment 142560 [details] [review] Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. Signed-off-by: David Nind <david@davidnind.com> Created attachment 142561 [details] [review] Bug 31911: (follow-up) Rename second level heading This patch, as suggested, renames the second level heading to 'Items in collection' and move the 'Total items: {count}' into a paragraph. Signed-off-by: David Nind <david@davidnind.com> Created attachment 142562 [details]
Screenshot - list of rotating collections
Something minor (and maybe for another bug) - do we need to show 'Showing 1 to 2 of 2 entries' on a separate line? See the screenshot.
I think on other screens (such as list of items for a record) we show on the same row as the DataTables header.
(In reply to David Nind from comment #9) > Created attachment 142562 [details] > Screenshot - list of rotating collections > > Something minor (and maybe for another bug) - do we need to show 'Showing 1 > to 2 of 2 entries' on a separate line? See the screenshot. > > I think on other screens (such as list of items for a record) we show on the > same row as the DataTables header. I think this has to do with today's changes to the datatable controls, unrelated to this bug. I see the same on the libraries page. I kinda like it, because the inofrmation was often missed before, but not sure if intentional or not. Pushed to master for 22.11. Nice work everyone, thanks! (In reply to Katrin Fischer from comment #10) > (In reply to David Nind from comment #9) > > Created attachment 142562 [details] > > Screenshot - list of rotating collections > > > > Something minor (and maybe for another bug) - do we need to show 'Showing 1 > > to 2 of 2 entries' on a separate line? See the screenshot. > > > > I think on other screens (such as list of items for a record) we show on the > > same row as the DataTables header. > > I think this has to do with today's changes to the datatable controls, > unrelated to this bug. I see the same on the libraries page. > > I kinda like it, because the inofrmation was often missed before, but not > sure if intentional or not. Thanks Katrin! |