|
Description
Katrin Fischer
2022-10-24 09:55:17 UTC
Created attachment 142581 [details] [review] Bug 31935: Fix misaligned form when adding serial subscription This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping <p> tags and adding labels where appropriate. To test: 1. Add a serial subscription and notice the misaligned form on step 1. 2. Apply patch 3. Look again and confirm that the form looks better. 4. Read through everything and make sure the form still makes sense. 5. Make sure the form still works properly. Created attachment 142591 [details]
Screenshot - new subscription form
A couple of things I noted (see the screenshot):
1. For When receiving this serial: when "Create an item record" is selected, the Collection and Item type fields are misaligned.
2. For vendor: no space after the closing bracket and before the search icon, also there is a space between the end of the form field and the bracket which looks odd.
3. For Record: no space after the closing bracket and before "Required", also there is a space between the end of the form field and the bracket which looks odd.
4. "Search for record" and "Create record" placement: looks "off" where they are at the moment - maybe should be aligned under the input field/help text.
I'd love to see this fixed before release as it's THE form in the serials module. Created attachment 144510 [details] [review] Bug 31935: ( follow-up ) Make form look better David, I addressed your comments in a follow-up. I removed the parenthesis around vendor and record. I thought they looked weird and don't really add anything. Cait, sorry I didn't get back to this one prior to the release. Hoping we can get it in for 22.11.01 Created attachment 144521 [details] [review] Bug 31935: Fix misaligned form when adding serial subscription This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping <p> tags and adding labels where appropriate. To test: 1. Add a serial subscription and notice the misaligned form on step 1. 2. Apply patch 3. Look again and confirm that the form looks better. 4. Read through everything and make sure the form still makes sense. 5. Make sure the form still works properly. Signed-off-by: David Nind <david@davidnind.com> Created attachment 144522 [details] [review] Bug 31935: ( follow-up ) Make form look better Signed-off-by: David Nind <david@davidnind.com> Created attachment 145025 [details] [review] Bug 31935: Fix misaligned form when adding serial subscription This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping <p> tags and adding labels where appropriate. To test: 1. Add a serial subscription and notice the misaligned form on step 1. 2. Apply patch 3. Look again and confirm that the form looks better. 4. Read through everything and make sure the form still makes sense. 5. Make sure the form still works properly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 145026 [details] [review] Bug 31935: (follow-up) Make form look better Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |