Bug 31935 - Serials subscription form is misaligned
Summary: Serials subscription form is misaligned
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords: rel_22_11_candidate
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-24 09:55 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the alignment of the serials subscription form.
Version(s) released in:
23.05.00,22.11.02


Attachments
Bug 31935: Fix misaligned form when adding serial subscription (5.57 KB, patch)
2022-10-24 22:57 UTC, Lucas Gass
Details | Diff | Splinter Review
Screenshot - new subscription form (92.77 KB, image/png)
2022-10-25 01:10 UTC, David Nind
Details
Bug 31935: ( follow-up ) Make form look better (3.81 KB, patch)
2022-12-08 21:13 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31935: Fix misaligned form when adding serial subscription (5.62 KB, patch)
2022-12-09 09:47 UTC, David Nind
Details | Diff | Splinter Review
Bug 31935: ( follow-up ) Make form look better (3.85 KB, patch)
2022-12-09 09:47 UTC, David Nind
Details | Diff | Splinter Review
Bug 31935: Fix misaligned form when adding serial subscription (5.70 KB, patch)
2023-01-04 15:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31935: (follow-up) Make form look better (3.93 KB, patch)
2023-01-04 15:57 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-24 09:55:17 UTC
The form for adding subscriptions is misaligned in the new design.
Comment 1 Lucas Gass 2022-10-24 22:57:14 UTC
Created attachment 142581 [details] [review]
Bug 31935: Fix misaligned form when adding serial subscription

This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping <p> tags and adding labels where appropriate.

To test:
1. Add a serial subscription and notice the misaligned form on step 1.
2. Apply patch
3. Look again and confirm that the form looks better.
4. Read through everything and make sure the form still makes sense.
5. Make sure the form still works properly.
Comment 2 David Nind 2022-10-25 01:10:57 UTC
Created attachment 142591 [details]
Screenshot - new subscription form

A couple of things I noted (see the screenshot):

1. For When receiving this serial: when "Create an item record" is selected, the Collection and Item type fields are misaligned.

2. For vendor: no space after the closing bracket and before the search icon, also there is a space between the end of the form field and the bracket which looks odd.

3. For Record: no space after the closing bracket and before "Required", also there is a space between the end of the form field and the bracket which looks odd.

4. "Search for record" and "Create record" placement: looks "off" where they are at the moment - maybe should be aligned under the input field/help text.
Comment 3 Katrin Fischer 2022-11-10 22:35:33 UTC
I'd love to see this fixed before release as it's THE form in the serials module.
Comment 4 Lucas Gass 2022-12-08 21:13:30 UTC
Created attachment 144510 [details] [review]
Bug 31935: ( follow-up ) Make form look better
Comment 5 Lucas Gass 2022-12-08 21:15:49 UTC
David, I addressed your comments in a follow-up. I removed the parenthesis around vendor and record. I thought they looked weird and don't really add anything. 

Cait, sorry I didn't get back to this one prior to the release. Hoping we can get it in for 22.11.01
Comment 6 David Nind 2022-12-09 09:47:47 UTC
Created attachment 144521 [details] [review]
Bug 31935: Fix misaligned form when adding serial subscription

This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping <p> tags and adding labels where appropriate.

To test:
1. Add a serial subscription and notice the misaligned form on step 1.
2. Apply patch
3. Look again and confirm that the form looks better.
4. Read through everything and make sure the form still makes sense.
5. Make sure the form still works properly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2022-12-09 09:47:52 UTC
Created attachment 144522 [details] [review]
Bug 31935: ( follow-up ) Make form look better

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 Jonathan Druart 2023-01-04 15:57:26 UTC
Created attachment 145025 [details] [review]
Bug 31935: Fix misaligned form when adding serial subscription

This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping <p> tags and adding labels where appropriate.

To test:
1. Add a serial subscription and notice the misaligned form on step 1.
2. Apply patch
3. Look again and confirm that the form looks better.
4. Read through everything and make sure the form still makes sense.
5. Make sure the form still works properly.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2023-01-04 15:57:31 UTC
Created attachment 145026 [details] [review]
Bug 31935: (follow-up) Make form look better

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Tomás Cohen Arazi 2023-01-05 12:26:35 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 11 Jacob O'Mara 2023-01-13 16:08:38 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.