Bug 31954

Summary: Patron search has no h1 heading
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Katrin Fischer <katrin.fischer>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: m.de.rooy
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 31954: Add h1 heading to patron search results page
Bug 31954: Add h1 heading to patron search results page

Description Katrin Fischer 2022-10-24 15:30:57 UTC
For accessibility every page should have an h1 level heading and have a clear hierarchical structure of headings.

Patron search only has 2 h3 headings.
Comment 1 Katrin Fischer 2023-01-06 22:16:04 UTC
Created attachment 145110 [details] [review]
Bug 31954: Add h1 heading to patron search results page

Havin an h1 heading on every page has been one of our
accessibility goals, but patron search results don't have
one so far.

To test:
* Apply patch
* Do a patron search
* Verify there is now an h1 heading between the toolbar
  and the patron search results table reading:
  Patron search results
Comment 2 David Nind 2023-01-07 10:52:33 UTC
Created attachment 145131 [details] [review]
Bug 31954: Add h1 heading to patron search results page

Havin an h1 heading on every page has been one of our
accessibility goals, but patron search results don't have
one so far.

To test:
* Apply patch
* Do a patron search
* Verify there is now an h1 heading between the toolbar
  and the patron search results table reading:
  Patron search results

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2023-01-13 10:20:42 UTC
This is fine for displayed results. But when I enter the form I already see it now and that is not correct ;)
Comment 4 Katrin Fischer 2023-01-13 11:31:20 UTC
Just to confirm: the edit patron form?
Comment 5 Marcel de Rooy 2023-01-20 10:06:18 UTC
(In reply to Katrin Fischer from comment #4)
> Just to confirm: the edit patron form?

No, patron search.
Comment 6 Katrin Fischer 2023-01-20 12:06:13 UTC
(In reply to Marcel de Rooy from comment #5)
> (In reply to Katrin Fischer from comment #4)
> > Just to confirm: the edit patron form?
> 
> No, patron search.

Sorry, didn't get to have a closer look yet. 

Just to make sure: it's intentional that the h1 always displays, there should always be a visible h1 on any page.