Bug 31954 - Patron search has no h1 heading
Summary: Patron search has no h1 heading
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-24 15:30 UTC by Katrin Fischer
Modified: 2023-01-20 12:06 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 31954: Add h1 heading to patron search results page (1.18 KB, patch)
2023-01-06 22:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31954: Add h1 heading to patron search results page (1.23 KB, patch)
2023-01-07 10:52 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-24 15:30:57 UTC
For accessibility every page should have an h1 level heading and have a clear hierarchical structure of headings.

Patron search only has 2 h3 headings.
Comment 1 Katrin Fischer 2023-01-06 22:16:04 UTC
Created attachment 145110 [details] [review]
Bug 31954: Add h1 heading to patron search results page

Havin an h1 heading on every page has been one of our
accessibility goals, but patron search results don't have
one so far.

To test:
* Apply patch
* Do a patron search
* Verify there is now an h1 heading between the toolbar
  and the patron search results table reading:
  Patron search results
Comment 2 David Nind 2023-01-07 10:52:33 UTC
Created attachment 145131 [details] [review]
Bug 31954: Add h1 heading to patron search results page

Havin an h1 heading on every page has been one of our
accessibility goals, but patron search results don't have
one so far.

To test:
* Apply patch
* Do a patron search
* Verify there is now an h1 heading between the toolbar
  and the patron search results table reading:
  Patron search results

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2023-01-13 10:20:42 UTC
This is fine for displayed results. But when I enter the form I already see it now and that is not correct ;)
Comment 4 Katrin Fischer 2023-01-13 11:31:20 UTC
Just to confirm: the edit patron form?
Comment 5 Marcel de Rooy 2023-01-20 10:06:18 UTC
(In reply to Katrin Fischer from comment #4)
> Just to confirm: the edit patron form?

No, patron search.
Comment 6 Katrin Fischer 2023-01-20 12:06:13 UTC
(In reply to Marcel de Rooy from comment #5)
> (In reply to Katrin Fischer from comment #4)
> > Just to confirm: the edit patron form?
> 
> No, patron search.

Sorry, didn't get to have a closer look yet. 

Just to make sure: it's intentional that the h1 always displays, there should always be a visible h1 on any page.