For accessibility every page should have an h1 level heading and have a clear hierarchical structure of headings. Patron search only has 2 h3 headings.
Created attachment 145110 [details] [review] Bug 31954: Add h1 heading to patron search results page Havin an h1 heading on every page has been one of our accessibility goals, but patron search results don't have one so far. To test: * Apply patch * Do a patron search * Verify there is now an h1 heading between the toolbar and the patron search results table reading: Patron search results
Created attachment 145131 [details] [review] Bug 31954: Add h1 heading to patron search results page Havin an h1 heading on every page has been one of our accessibility goals, but patron search results don't have one so far. To test: * Apply patch * Do a patron search * Verify there is now an h1 heading between the toolbar and the patron search results table reading: Patron search results Signed-off-by: David Nind <david@davidnind.com>
This is fine for displayed results. But when I enter the form I already see it now and that is not correct ;)
Just to confirm: the edit patron form?
(In reply to Katrin Fischer from comment #4) > Just to confirm: the edit patron form? No, patron search.
(In reply to Marcel de Rooy from comment #5) > (In reply to Katrin Fischer from comment #4) > > Just to confirm: the edit patron form? > > No, patron search. Sorry, didn't get to have a closer look yet. Just to make sure: it's intentional that the h1 always displays, there should always be a visible h1 on any page.