Description
Owen Leonard
2022-10-27 18:17:46 UTC
Created attachment 142731 [details] [review] Bug 32022: Style tweaks to fieldsets and page-section This patch makes CSS changes to try to bring some consistency to various elements which are similar in the general sense of "white box." Fieldsets, page-section, etc. To test apply the patch and rebuild the staff interface CSS. Test various pages with page-section, fieldsets, etc.: - Patron details - Patron edit - Patron accounting - Check Tools -> Patron lists -> New to confirm that there is not a gap between the submit button's container and the rest of the form. *** Bug 31904 has been marked as a duplicate of this bug. *** Generally I like the consistency here.. one minor thing I wonder a bit about.. by making the 'action' fieldset also have a white background it makes it appear like the buttons are now part of that fieldset.. I think I like the spacing but would prefer the background remain the grey so the buttons appear to be distinct but related as they did before the whole refresh? Created attachment 142750 [details] [review] Bug 32022: Style tweaks to fieldsets and page-section This patch makes CSS changes to try to bring some consistency to various elements which are similar in the general sense of "white box." Fieldsets, page-section, etc. To test apply the patch and rebuild the staff interface CSS. Test various pages with page-section, fieldsets, etc.: - Patron details - Patron edit - Patron accounting - Check Tools -> Patron lists -> New to confirm that there is not a gap between the submit button's container and the rest of the form. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 142751 [details] [review] Bug 32022: (follow-up) Ensure action background takes presidence The action class sets the background to transparent, but because it's often used in conjunction with the fieldset which includes the card mixin the background rule was getting overridden to white. Test plan 1. Consider the same cases as the original patch 2. Confirm that the last test now shows the buttons outside of the card but nicely spaced to clearly belong to it. Created attachment 142753 [details] [review] Bug 32022: Style tweaks to fieldsets and page-section This patch makes CSS changes to try to bring some consistency to various elements which are similar in the general sense of "white box." Fieldsets, page-section, etc. To test apply the patch and rebuild the staff interface CSS. Test various pages with page-section, fieldsets, etc.: - Patron details - Patron edit - Patron accounting - Check Tools -> Patron lists -> New to confirm that there is not a gap between the submit button's container and the rest of the form. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 142754 [details] [review] Bug 32022: (follow-up) Ensure action background takes presidence The action class sets the background to transparent, but because it's often used in conjunction with the fieldset which includes the card mixin the background rule was getting overridden to white. Test plan 1. Consider the same cases as the original patch 2. Confirm that the last test now shows the buttons outside of the card but nicely spaced to clearly belong to it. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.11. Nice work everyone, thanks! Created attachment 153615 [details]
picture of form in 22.11.06
Created attachment 153616 [details]
picture of form in master
This made the "Submit" button very close the form, is this intentional? Possible conflict with 32605? One adds a margin to .rows and the other adds it to the .action fieldset (In reply to Pedro Amorim from comment #11) > This made the "Submit" button very close the form, is this intentional? It's the patch for Bug 34072 that caused this. I'm trying to figure out what the original problem looked like so I can try to address the side-effect. (In reply to Owen Leonard from comment #13) > (In reply to Pedro Amorim from comment #11) > > This made the "Submit" button very close the form, is this intentional? > > It's the patch for Bug 34072 that caused this. I'm trying to figure out what > the original problem looked like so I can try to address the side-effect. Sorry for that one :( I could see the issue in testing, I didn't spot side effects but I should have looked harder. |