Bug 32054

Created attachment 142838 [details] [review]
Bug 32054: Add get_import_record_matches object method and use it

Thispatch adds the new method and alters addorderiso2907.pl to use this
rather than GetRecordImportMatches

To test:
 1 - Import the attached record several times
 2 - Set up a matching rule:
    TitleAuthor threshold: 100
    Matchpoint:
    search index: title, score: 100, tag: 245$a
    search index: author, score: 100, tag:100$a
 3 - Edit one of the imported records to have a different author
 4 - Stage the file again. and match using the matchpoint above
 5 - Note that matches are found and listed on batch management, with the lowest scored match last
 6 - Choose that match
 7 - In acquisitions, add to a basket from the staged file
 8 - Check the box for the record
 9 - Note the match lists the biblionumber for the highest scoring match, not the chosen one
10 - Add an order and note it is for the wrong biblio
11 - Appy patch
12 - Restart_all
13 - Stage the file again and choose a lower scoring match
14 - Confirm when adding to basket this match is preserved
15 - Complete order and verify correct biblio ordered
16 - Stage again, select no match
17 - Confirm no match listed when adding to basket, and choose 'Do not look for matching records' while adding
18 - Confirm order is created on a new biblio

I'm happy to try and test, however there is no attached record (step 1 of the test plan).

Created attachment 142896 [details]
Sample biblio from sample database

Created attachment 143293 [details] [review]
Bug 32054: Add get_import_record_matches object method and use it

Thispatch adds the new method and alters addorderiso2907.pl to use this
rather than GetRecordImportMatches

To test:
 1 - Import the attached record several times
 2 - Set up a matching rule:
    TitleAuthor threshold: 100
    Matchpoint:
    search index: title, score: 100, tag: 245$a
    search index: author, score: 100, tag:100$a
 3 - Edit one of the imported records to have a different author
 4 - Stage the file again. and match using the matchpoint above
 5 - Note that matches are found and listed on batch management, with the lowest scored match last
 6 - Choose that match
 7 - In acquisitions, add to a basket from the staged file
 8 - Check the box for the record
 9 - Note the match lists the biblionumber for the highest scoring match, not the chosen one
10 - Add an order and note it is for the wrong biblio
11 - Appy patch
12 - Restart_all
13 - Stage the file again and choose a lower scoring match
14 - Confirm when adding to basket this match is preserved
15 - Complete order and verify correct biblio ordered
16 - Stage again, select no match
17 - Confirm no match listed when adding to basket, and choose 'Do not look for matching records' while adding
18 - Confirm order is created on a new biblio

Signed-off-by: David Nind <david@davidnind.com>

I think I tested this correctly - this is the first time I've used matching rules and adding to an order from a staged record.

Mainly found the options for steps 14-15, and the duplicate record message and choices, a bit confusing.

This patch leaves us with one actual remaining call of GetImportRecordMatches:

C4/ImportBatch.pm:      GetImportRecordMatches
C4/ImportBatch.pm:=head2 GetImportRecordMatches
C4/ImportBatch.pm:  my $results = GetImportRecordMatches($import_record_id, $best_only);
C4/ImportBatch.pm:sub GetImportRecordMatches {
tools/batch_records_ajax.pl:use C4::ImportBatch qw( GetImportBatch GetImportRecordsRange GetImportRecordMatches );
tools/batch_records_ajax.pl:    my $matches = GetImportRecordMatches( $record->{'import_record_id'} );

The last one is the only real one.

koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt:                    "sAjaxSource": 'batch_records_ajax.pl',

Having issues with the background jobs here. The staged file job is stuck on New status. Restarted stuff etc. No change at all. Logs dont make me wiser. Please confirm if it still works..

(In reply to Marcel de Rooy from comment #7)
> Having issues with the background jobs here. The staged file job is stuck on
> New status. Restarted stuff etc. No change at all. Logs dont make me wiser.
> Please confirm if it still works..

I am able to stage and import without issue

(In reply to Nick Clemens from comment #8)
> (In reply to Marcel de Rooy from comment #7)
> > Having issues with the background jobs here. The staged file job is stuck on
> > New status. Restarted stuff etc. No change at all. Logs dont make me wiser.
> > Please confirm if it still works..
> 
> I am able to stage and import without issue

Resolved that now ;) background_jobs..

We could go ahead but we could also try here to remove the last occurrence. What do you think? See comment6.

(In reply to Marcel de Rooy from comment #10)
> We could go ahead but we could also try here to remove the last occurrence.
> What do you think? See comment6.

The real fix there is to remove that script and use API to build the datatables - we could update it to remove the use, but it feels like it would be double work. Either way, I think that should be on its own report

Created attachment 145360 [details] [review]
Bug 32054: Add get_import_record_matches object method and use it

Thispatch adds the new method and alters addorderiso2907.pl to use this
rather than GetRecordImportMatches

To test:
 1 - Import the attached record several times
 2 - Set up a matching rule:
    TitleAuthor threshold: 100
    Matchpoint:
    search index: title, score: 100, tag: 245$a
    search index: author, score: 100, tag:100$a
 3 - Edit one of the imported records to have a different author
 4 - Stage the file again. and match using the matchpoint above
 5 - Note that matches are found and listed on batch management, with the lowest scored match last
 6 - Choose that match
 7 - In acquisitions, add to a basket from the staged file
 8 - Check the box for the record
 9 - Note the match lists the biblionumber for the highest scoring match, not the chosen one
10 - Add an order and note it is for the wrong biblio
11 - Appy patch
12 - Restart_all
13 - Stage the file again and choose a lower scoring match
14 - Confirm when adding to basket this match is preserved
15 - Complete order and verify correct biblio ordered
16 - Stage again, select no match
17 - Confirm no match listed when adding to basket, and choose 'Do not look for matching records' while adding
18 - Confirm order is created on a new biblio

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Nice work everyone!

Pushed to 23.05.x for the next release

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.