Bug 32055

Summary: Remove GetImportRecordMatches
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: ToolsAssignee: Eric Garcia <cubingguy714>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: lucas, phil
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 31710    
Bug Blocks:    
Attachments: Bug 32055: Change code to use get_import_record_matches
Bug 32055: Removed GetImportRecordMatches subroutine
Bug 32055: Removed GetImportRecordMatches subroutine
Bug 32055: Change code to use get_import_record_matches
Bug 32055: Removed GetImportRecordMatches subroutine

Description Nick Clemens (kidclamp) 2022-10-31 18:17:24 UTC
Bug 32054 removes most uses, we should finish the job
Comment 1 Eric Garcia 2024-08-08 19:30:46 UTC
Created attachment 170163 [details] [review]
Bug 32055: Change code to use get_import_record_matches

To test:
1. Apply patch, restart_all

Bibliographic records:
2. Cataloging -> Stage records for import
3. Choose a file with bibliographic records
4. Choose a record matching rule -> Save
5. View batch and notice the table displays the information correctly

Authority records:
6. Administration -> Record matching rules -> New record matching rule
7. Add a code, description, and Match Threshold: 1000
8. Match point 1:
    Search index: local-number
    Score: 1000
    Tag: 001
9. Save
10. Cataloging -> Stage records for import
11. Choose a file with authority records
12. Change Record type to 'Authority' and choose the matching rule you made previously
13. View batch and notice the table displays the information correctly
Comment 2 Eric Garcia 2024-08-08 19:30:48 UTC
Created attachment 170164 [details] [review]
Bug 32055: Removed GetImportRecordMatches subroutine
Comment 3 William Lavoie 2025-01-13 15:18:29 UTC
Created attachment 176454 [details] [review]
Bug 32055: Removed GetImportRecordMatches subroutine

Signed-off-by: William Lavoie <william.lavoie@inLibro.com>
Comment 4 Nick Clemens (kidclamp) 2025-03-31 09:24:07 UTC
Created attachment 179938 [details] [review]
Bug 32055: Change code to use get_import_record_matches

To test:
1. Apply patch, restart_all

Bibliographic records:
2. Cataloging -> Stage records for import
3. Choose a file with bibliographic records
4. Choose a record matching rule -> Save
5. View batch and notice the table displays the information correctly

Authority records:
6. Administration -> Record matching rules -> New record matching rule
7. Add a code, description, and Match Threshold: 1000
8. Match point 1:
    Search index: local-number
    Score: 1000
    Tag: 001
9. Save
10. Cataloging -> Stage records for import
11. Choose a file with authority records
12. Change Record type to 'Authority' and choose the matching rule you made previously
13. View batch and notice the table displays the information correctly
Comment 5 Nick Clemens (kidclamp) 2025-03-31 09:24:09 UTC
Created attachment 179939 [details] [review]
Bug 32055: Removed GetImportRecordMatches subroutine

Signed-off-by: William Lavoie <william.lavoie@inLibro.com>
Comment 6 Lucas Gass (lukeg) 2025-11-07 15:22:29 UTC
[FAIL] tools/batch_records_ajax.pl
   FAIL	  tidiness
		File is not tidy, please run `perl misc/devel/tidy.pl tools/batch_records_ajax.pl`
   FAIL	  valid
		"GetImportRecordMathes" is not exported by the C4::ImportBatch module
		Can't continue after import errors