Bug 32055 - Remove GetImportRecordMatches
Summary: Remove GetImportRecordMatches
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Eric Garcia
QA Contact: Testopia
URL:
Keywords:
Depends on: 31710
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-31 18:17 UTC by Nick Clemens (kidclamp)
Modified: 2025-03-31 09:24 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 32055: Change code to use get_import_record_matches (4.49 KB, patch)
2024-08-08 19:30 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 32055: Removed GetImportRecordMatches subroutine (1.95 KB, patch)
2024-08-08 19:30 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 32055: Removed GetImportRecordMatches subroutine (2.00 KB, patch)
2025-01-13 15:18 UTC, William Lavoie
Details | Diff | Splinter Review
Bug 32055: Change code to use get_import_record_matches (5.50 KB, patch)
2025-03-31 09:24 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 32055: Removed GetImportRecordMatches subroutine (2.04 KB, patch)
2025-03-31 09:24 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2022-10-31 18:17:24 UTC
Bug 32054 removes most uses, we should finish the job
Comment 1 Eric Garcia 2024-08-08 19:30:46 UTC
Created attachment 170163 [details] [review]
Bug 32055: Change code to use get_import_record_matches

To test:
1. Apply patch, restart_all

Bibliographic records:
2. Cataloging -> Stage records for import
3. Choose a file with bibliographic records
4. Choose a record matching rule -> Save
5. View batch and notice the table displays the information correctly

Authority records:
6. Administration -> Record matching rules -> New record matching rule
7. Add a code, description, and Match Threshold: 1000
8. Match point 1:
    Search index: local-number
    Score: 1000
    Tag: 001
9. Save
10. Cataloging -> Stage records for import
11. Choose a file with authority records
12. Change Record type to 'Authority' and choose the matching rule you made previously
13. View batch and notice the table displays the information correctly
Comment 2 Eric Garcia 2024-08-08 19:30:48 UTC
Created attachment 170164 [details] [review]
Bug 32055: Removed GetImportRecordMatches subroutine
Comment 3 William Lavoie 2025-01-13 15:18:29 UTC
Created attachment 176454 [details] [review]
Bug 32055: Removed GetImportRecordMatches subroutine

Signed-off-by: William Lavoie <william.lavoie@inLibro.com>
Comment 4 Nick Clemens (kidclamp) 2025-03-31 09:24:07 UTC
Created attachment 179938 [details] [review]
Bug 32055: Change code to use get_import_record_matches

To test:
1. Apply patch, restart_all

Bibliographic records:
2. Cataloging -> Stage records for import
3. Choose a file with bibliographic records
4. Choose a record matching rule -> Save
5. View batch and notice the table displays the information correctly

Authority records:
6. Administration -> Record matching rules -> New record matching rule
7. Add a code, description, and Match Threshold: 1000
8. Match point 1:
    Search index: local-number
    Score: 1000
    Tag: 001
9. Save
10. Cataloging -> Stage records for import
11. Choose a file with authority records
12. Change Record type to 'Authority' and choose the matching rule you made previously
13. View batch and notice the table displays the information correctly
Comment 5 Nick Clemens (kidclamp) 2025-03-31 09:24:09 UTC
Created attachment 179939 [details] [review]
Bug 32055: Removed GetImportRecordMatches subroutine

Signed-off-by: William Lavoie <william.lavoie@inLibro.com>