Bug 32082

Summary: CanBookBeReserved with itype option is a different subroutine and should be split out
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: arthur.suzuki, gmcharlt
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Nick Clemens (kidclamp) 2022-11-03 10:01:31 UTC
The call to this routine with param itemtype is self contained code that in fact checks CanItemtypeBeReserved

Calling it as CanBookBeReturned passes ReservesControlBranch as pickup_location - it's a bad smell