Bug 32084

Summary: GetMaxPatronHoldsForRecord is incorrect and inefficient
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, kyle
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Nick Clemens (kidclamp) 2022-11-03 10:31:53 UTC
This routine claims to return the max number of holds a patron can place on a record, however, it does not take into account whether a patron can hold an itemtype or not, so may be inflating the maximum number when the patron cannot in fact hold those items

Additionally, the routine makes a call for effective circulation rule per item.

We really only need to call once per itemtype and branch combination - if reserves control branch is 'patrons library' then it is really only once per itemtype on the biblio