Bug 32084 - GetMaxPatronHoldsForRecord is incorrect and inefficient
Summary: GetMaxPatronHoldsForRecord is incorrect and inefficient
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-03 10:31 UTC by Nick Clemens (kidclamp)
Modified: 2022-11-03 10:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2022-11-03 10:31:53 UTC
This routine claims to return the max number of holds a patron can place on a record, however, it does not take into account whether a patron can hold an itemtype or not, so may be inflating the maximum number when the patron cannot in fact hold those items

Additionally, the routine makes a call for effective circulation rule per item.

We really only need to call once per itemtype and branch combination - if reserves control branch is 'patrons library' then it is really only once per itemtype on the biblio