Summary: | Consistent classes for primary buttons: Patron card creator | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 32067 | ||
Attachments: |
Bug 32088: Consistent classes for primary buttons: Patron card creator
Bug 32088: Consistent classes for primary buttons: Patron card creator Bug 32088: Consistent classes for primary buttons: Patron card creator |
Description
Owen Leonard
2022-11-03 12:16:00 UTC
Created attachment 143110 [details] [review] Bug 32088: Consistent classes for primary buttons: Patron card creator This patch makes changes the button markup in patron card creator templates so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view patron card creator pages to confirm that everything looks correct. In most cases there are no visible changes. Created attachment 143342 [details] [review] Bug 32088: Consistent classes for primary buttons: Patron card creator This patch makes changes the button markup in patron card creator templates so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view patron card creator pages to confirm that everything looks correct. In most cases there are no visible changes. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD). 1. These changed templates accessed from: Tools > Patrons and circulation > Patron card creator 2. I tested by: - Reviewing the patch - <input type="submit"... becomes <input type="submit" class="btn btn-primary"... - Listing the templates in koha-tmpl/intranet-tmpl/prog/en/modules/patroncards and splitting into two lists - those changed and those not changed - Working out how to access them - Creating screenshots and putting them in a document (I haven't attached this, but am happy to) - Applying the patch (+ flush_memcached, restart_all, and cleared browser cache) - Going through the list of files again: compared to original screenshot taken, then noted whether changed or not - Noting any questions - these don't affect the sign off for this bug 3. Files changed: - edit-layout.tt (No visible change. Manage > Layouts > select the 'Edit' action for a layout) (same template used to add new layouts) - edit-profile.tt (No visible change. Manage > Printer profiles > select the 'Edit' action for a printer) (same template used to add new printer profiles) - edit-template.tt (No visible change. Manage > Card templates > select the 'Edit' action for a template) (same template used to add new card templates) - image-manage.tt (No visible change. Manage > Images) (Bonus - add an image) (same template used to add and delete images) - print.tt (No visible change. New > Card batch > enter borrowernumbers > Add patron > select Export card batch option) 4. Files not changed: - edit-batch.tt (Manage > Card batches > [select the 'Edit' action for a batch] or [select a batch and the 'Export selected batches'] - home.tt (Patron card creator home page - no buttons apart from toolbar) - manage.tt (used to either add or edit batches (or print selected batches from a list of batches), images, layouts, card templates and printer profiles) 5. File count check: - Number of files in folder: 8 - Number of files listed: 8 (5 changed in this patch) Question 1. Should the buttons be in the div or outisde the div? Those in the white background are: - Image manager: the upload button is inside the white div area Created attachment 143514 [details] [review] Bug 32088: Consistent classes for primary buttons: Patron card creator This patch makes changes the button markup in patron card creator templates so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view patron card creator pages to confirm that everything looks correct. In most cases there are no visible changes. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! |