Bug 32088 - Consistent classes for primary buttons: Patron card creator
Summary: Consistent classes for primary buttons: Patron card creator
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 32067
  Show dependency treegraph
 
Reported: 2022-11-03 12:16 UTC by Owen Leonard
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32088: Consistent classes for primary buttons: Patron card creator (5.31 KB, patch)
2022-11-03 13:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32088: Consistent classes for primary buttons: Patron card creator (5.36 KB, patch)
2022-11-06 13:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 32088: Consistent classes for primary buttons: Patron card creator (5.42 KB, patch)
2022-11-09 13:51 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-03 12:16:00 UTC
As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary buttons:

This patch will update buttons in patron card creator templates so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes.

In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary.
Comment 1 Owen Leonard 2022-11-03 13:05:43 UTC
Created attachment 143110 [details] [review]
Bug 32088: Consistent classes for primary buttons: Patron card creator

This patch makes changes the button markup in patron card creator
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view patron card creator pages to confirm
that everything looks correct. In most cases there are no visible
changes.
Comment 2 David Nind 2022-11-06 13:22:30 UTC
Created attachment 143342 [details] [review]
Bug 32088: Consistent classes for primary buttons: Patron card creator

This patch makes changes the button markup in patron card creator
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view patron card creator pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-11-06 13:25:16 UTC
Testing notes (using KTD).

1. These changed templates accessed from: Tools > Patrons and circulation > Patron card creator
   
2. I tested by:
   - Reviewing the patch - <input type="submit"... becomes <input type="submit" class="btn btn-primary"...
   - Listing the templates in koha-tmpl/intranet-tmpl/prog/en/modules/patroncards and splitting into two lists - those changed and those not changed
   - Working out how to access them
   - Creating screenshots and putting them in a document (I haven't attached this, but am happy to)
   - Applying the patch (+ flush_memcached, restart_all, and cleared browser cache)
   - Going through the list of files again: compared to original screenshot taken, then noted whether changed or not
   - Noting any questions - these don't affect the sign off for this bug
   
3. Files changed:
   - edit-layout.tt (No visible change. Manage > Layouts > select the 'Edit' action for a layout) (same template used to add new layouts)
   - edit-profile.tt (No visible change. Manage > Printer profiles > select the 'Edit' action for a printer) (same template used to add new printer profiles)
   - edit-template.tt (No visible change. Manage > Card templates > select the 'Edit' action for a template) (same template used to add new card templates)
   - image-manage.tt (No visible change. Manage > Images) (Bonus - add an image) (same template used to add and delete images)
   - print.tt (No visible change. New > Card batch > enter borrowernumbers > Add patron > select Export card batch option)

4. Files not changed:
   - edit-batch.tt (Manage > Card batches > [select the 'Edit' action for a batch] or [select a batch and the 'Export selected batches']
   - home.tt (Patron card creator home page - no buttons apart from toolbar)
   - manage.tt (used to either add or edit batches (or print selected batches from a list of batches), images, layouts, card templates and printer profiles)

5. File count check:
   - Number of files in folder: 8
   - Number of files listed: 8 (5 changed in this patch)

Question

1. Should the buttons be in the div or outisde the div? Those in the white background are:
   - Image manager: the upload button is inside the white div area
Comment 4 Katrin Fischer 2022-11-09 13:51:29 UTC
Created attachment 143514 [details] [review]
Bug 32088: Consistent classes for primary buttons: Patron card creator

This patch makes changes the button markup in patron card creator
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view patron card creator pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-11-09 17:40:18 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!