Summary: | Content field in HTML customizations is too narrow ( CodeMirror ) | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Tools | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | dcook, tomascohen |
Version: | Main | Keywords: | rel_22_11_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 30952 | ||
Bug Blocks: | |||
Attachments: |
Bug 32103: Remove flex from tab-content list elements
Bug 32103: Remove flex from tab-content list elements Bug 32103: Remove flex from tab-content list elements |
Description
Lucas Gass (lukeg)
2022-11-03 21:20:16 UTC
I can focus with my mouse but it is difficult the CodeMirror-wrap is only as wide as the content, so when there is no content it is very small. Ahh, it's because the list element now uses flex. Perhaps this particular content should not do that. We can remedy it by removing the rows class. Created attachment 143153 [details] [review] Bug 32103: Remove flex from tab-content list elements To test: 1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror ) 2. It is hard to focus on the Content field because the wrapper width is very small. 3. Apply patch and try again 4. The CodeMirror wrapper width should be normal again. 5. Check the other language tabs. 6. Also test the WYSIWYG editor, it should also be normal. Note: I added some CSS to make the labels appear bold. Created attachment 143736 [details] [review] Bug 32103: Remove flex from tab-content list elements To test: 1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror ) 2. It is hard to focus on the Content field because the wrapper width is very small. 3. Apply patch and try again 4. The CodeMirror wrapper width should be normal again. 5. Check the other language tabs. 6. Also test the WYSIWYG editor, it should also be normal. Note: I added some CSS to make the labels appear bold. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 143827 [details] [review] Bug 32103: Remove flex from tab-content list elements To test: 1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror ) 2. It is hard to focus on the Content field because the wrapper width is very small. 3. Apply patch and try again 4. The CodeMirror wrapper width should be normal again. 5. Check the other language tabs. 6. Also test the WYSIWYG editor, it should also be normal. Note: I added some CSS to make the labels appear bold. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! |