Bug 32103 - Content field in HTML customizations is too narrow ( CodeMirror )
Summary: Content field in HTML customizations is too narrow ( CodeMirror )
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords: rel_22_11_candidate
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-03 21:20 UTC by Lucas Gass
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32103: Remove flex from tab-content list elements (1.86 KB, patch)
2022-11-03 22:12 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32103: Remove flex from tab-content list elements (1.92 KB, patch)
2022-11-10 22:59 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32103: Remove flex from tab-content list elements (1.97 KB, patch)
2022-11-14 12:40 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-11-03 21:20:16 UTC
To recreate:

1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror )
2. Trying using your mouse to focus on the content field. You cannot gain focus. 
3. I can use my tab key to focus on the field.
Comment 1 Lucas Gass 2022-11-03 21:38:21 UTC
I can focus with my mouse but it is difficult the CodeMirror-wrap is only as wide as the content, so when there is no content it is very small.
Comment 2 Lucas Gass 2022-11-03 22:03:17 UTC
Ahh, it's because the list element now uses flex. Perhaps this particular content should not do that. We can remedy it by removing the rows class.
Comment 3 Lucas Gass 2022-11-03 22:12:36 UTC
Created attachment 143153 [details] [review]
Bug 32103: Remove flex from tab-content list elements

To test:
1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror )
2. It is hard to focus on the Content field because the wrapper width is very small.
3. Apply patch and try again
4. The CodeMirror wrapper width should be normal again.
5. Check the other language tabs.
6. Also test the WYSIWYG editor, it should also be normal.

Note: I added some CSS to make the labels appear bold.
Comment 4 Katrin Fischer 2022-11-10 22:59:48 UTC
Created attachment 143736 [details] [review]
Bug 32103: Remove flex from tab-content list elements

To test:
1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror )
2. It is hard to focus on the Content field because the wrapper width is very small.
3. Apply patch and try again
4. The CodeMirror wrapper width should be normal again.
5. Check the other language tabs.
6. Also test the WYSIWYG editor, it should also be normal.

Note: I added some CSS to make the labels appear bold.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-11-14 12:40:21 UTC
Created attachment 143827 [details] [review]
Bug 32103: Remove flex from tab-content list elements

To test:
1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror )
2. It is hard to focus on the Content field because the wrapper width is very small.
3. Apply patch and try again
4. The CodeMirror wrapper width should be normal again.
5. Check the other language tabs.
6. Also test the WYSIWYG editor, it should also be normal.

Note: I added some CSS to make the labels appear bold.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi 2022-11-14 12:41:19 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!