Bug 32114

Summary: Template error in OPAC search results RSS
Product: Koha Reporter: Owen Leonard <oleonard>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: major    
Priority: P5 - low CC: bugzilla, lucas, m.de.rooy, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08
Bug Depends on:    
Bug Blocks: 28307    
Attachments: Bug 32114: Add missing html_helpers.inc
Bug 32114: Add missing html_helpers.inc
Bug 32114: Add missing html_helpers.inc

Description Owen Leonard 2022-11-05 15:57:12 UTC
Found during testing of Bug 28307:

> But I get the following error when
> clicking on the RSS feed for a search results page: 
> Template process failed: file error - biblio_a_href: not found at
> /kohadevbox/koha/C4/Templates.pm line 127
Comment 1 Owen Leonard 2022-11-05 16:05:40 UTC
Created attachment 143297 [details] [review]
Bug 32114: Add missing html_helpers.inc

This patch makes a minor modification to the OPAC
search results RSS template so that an error isn't
triggered. The html_helpers include was missing.

To test, apply the patch and perform a catalog
search in the OPAC which will return results.

At the end of the "Your search results" heading
you should see an orange RSS icon. Clicking on it
should take you to an RSS feed instead of an
error page.
Comment 2 David Nind 2022-11-05 17:53:38 UTC
Created attachment 143298 [details] [review]
Bug 32114: Add missing html_helpers.inc

This patch makes a minor modification to the OPAC
search results RSS template so that an error isn't
triggered. The html_helpers include was missing.

To test, apply the patch and perform a catalog
search in the OPAC which will return results.

At the end of the "Your search results" heading
you should see an orange RSS icon. Clicking on it
should take you to an RSS feed instead of an
error page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-09 12:16:31 UTC
Created attachment 143495 [details] [review]
Bug 32114: Add missing html_helpers.inc

This patch makes a minor modification to the OPAC
search results RSS template so that an error isn't
triggered. The html_helpers include was missing.

To test, apply the patch and perform a catalog
search in the OPAC which will return results.

At the end of the "Your search results" heading
you should see an orange RSS icon. Clicking on it
should take you to an RSS feed instead of an
error page.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-09 13:07:27 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass 2022-12-21 16:55:03 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 6 Marcel de Rooy 2023-01-11 13:11:31 UTC
This has been backported to 21.11.x too. But it is actually not needed there. It does not use BLOCK biblio_a_href.
Comment 7 wainuiwitikapark 2023-03-15 01:19:59 UTC
Not backported to 21.05.x