+1

This only works for me if I turn on an additional image service, like Amazon. Both detail.tt and results.tt have a line like:

[% IF ( AmazonCoverImages  || LocalCoverImages || AdlibrisEnabled || (Koha.Preference('CustomCoverImages') && Koha.Preference('Cu    stomCoverImagesURL')) ) %]

I *think* BakerTaylorEnabled should be added there because B&T should be able to display without any of the other cover image services turned on?

Having a look here - I can' test BakerTaylor content, so having a real close look at the code.

As Owen pointed out this was not present before, so I think the small thing here is that the pref description was wrong before, but the big thing is that we add the content to staff! So I took the liberty to adjust the pref description a bit (change back if you hate it)

As we rename the pref for the OPAC, I expected a lot more name changes there. Checking with git grep I believe some were missed:

koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF ( BakerTaylorEnabled ) %]
koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc:                            [% IF ( OPACLocalCoverImages || OPACAmazonCoverImages || ( SyndeticsEnabled && SyndeticsCoverImages ) || GoogleJackets || BakerTaylorEnabled || ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) || ( Koha.Preference('OPACCustomCoverImages') AND Koha.Preference('CustomCoverImagesURL') ) ) %]
koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc:                                    [% IF ( BakerTaylorEnabled ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt:[% IF ( BakerTaylorEnabled ) %][% IF bt_id %]<a href="https://[% BakerTaylorBookstoreURL |url %][% bt_id | uri %]"><img alt="See Baker &amp; Taylor" src="[% BakerTaylorImageURL |url %][% bt_id | uri %]" /></a>[% END %][% END %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt:                                                [% IF BakerTaylorEnabled %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:                                                        [% IF ( BakerTaylorEnabled && !BakerTaylorBookstoreURL ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:                                                    [% IF ( BakerTaylorEnabled && BakerTaylorBookstoreURL ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                                                            [% IF ( Koha.Preference('BakerTaylorEnabled') && !Koha.Preference('BakerTaylorBookstoreURL') ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                                                            [% IF ( Koha.Preference('BakerTaylorEnabled') && Koha.Preference('BakerTaylorBookstoreURL') ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt:[% IF ( BakerTaylorEnabled && bt_id ) %]<a href="https://[% BakerTaylorBookstoreURL | uri %][% bt_id | uri %]"><img alt="See Baker &amp; Taylor" src="[% BakerTaylorImageURL | html %][% bt_id | html %]" /></a>[% END %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt:                                        [% IF ( BakerTaylorEnabled ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:                                                    [% IF ( BakerTaylorEnabled ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:                                                    [% IF ( BakerTaylorEnabled ) %]

Only seeing this one was changed:

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt:                        [% IF ( OPACBakerTaylorEnabled && bt_id ) %]

I think the issue is in the test plan, it should be: Disable staff interface and only enable OPAC. Verify it all still shows correctly.

(In reply to Katrin Fischer from comment #7)
> Having a look here - I can' test BakerTaylor content, so having a real close
> look at the code.
> 
> As Owen pointed out this was not present before, so I think the small thing
> here is that the pref description was wrong before, but the big thing is
> that we add the content to staff! So I took the liberty to adjust the pref
> description a bit (change back if you hate it)
> 
> As we rename the pref for the OPAC, I expected a lot more name changes
> there. Checking with git grep I believe some were missed:
> 
> koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF (
> BakerTaylorEnabled ) %]
> koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc:                 
> [% IF ( OPACLocalCoverImages || OPACAmazonCoverImages || ( SyndeticsEnabled
> && SyndeticsCoverImages ) || GoogleJackets || BakerTaylorEnabled || (
> Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) || (
> Koha.Preference('OPACCustomCoverImages') AND
> Koha.Preference('CustomCoverImagesURL') ) ) %]
> koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc:                 
> [% IF ( BakerTaylorEnabled ) %]
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt:[% IF (
> BakerTaylorEnabled ) %][% IF bt_id %]<a href="https://[%
> BakerTaylorBookstoreURL |url %][% bt_id | uri %]"><img alt="See Baker &amp;
> Taylor" src="[% BakerTaylorImageURL |url %][% bt_id | uri %]" /></a>[% END
> %][% END %]
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt:             
> [% IF BakerTaylorEnabled %]
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:                   
> [% IF ( BakerTaylorEnabled && !BakerTaylorBookstoreURL ) %]
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:                   
> [% IF ( BakerTaylorEnabled && BakerTaylorBookstoreURL ) %]
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                   
> [% IF ( Koha.Preference('BakerTaylorEnabled') &&
> !Koha.Preference('BakerTaylorBookstoreURL') ) %]
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                   
> [% IF ( Koha.Preference('BakerTaylorEnabled') &&
> Koha.Preference('BakerTaylorBookstoreURL') ) %]
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt:[% IF (
> BakerTaylorEnabled && bt_id ) %]<a href="https://[% BakerTaylorBookstoreURL
> | uri %][% bt_id | uri %]"><img alt="See Baker &amp; Taylor" src="[%
> BakerTaylorImageURL | html %][% bt_id | html %]" /></a>[% END %]
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt:               
> [% IF ( BakerTaylorEnabled ) %]
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:                      
> [% IF ( BakerTaylorEnabled ) %]
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:                      
> [% IF ( BakerTaylorEnabled ) %]
> 
> Only seeing this one was changed:
> 
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt:                    
> [% IF ( OPACBakerTaylorEnabled && bt_id ) %]
> 
> I think the issue is in the test plan, it should be: Disable staff interface
> and only enable OPAC. Verify it all still shows correctly.

Excuse my confusion here, I'd like to see this one move on. Do we need to edit code or only the test plan?

We definitely need a follow-up patch (code change) for all the places the syspref rename has not taken into account.

To explain a bit more: we have a pref now that is "Opac...", but in the OPAC scripts the old name is still used almost everywhere.

I believe the test plan should maybe be altered to in that you have to verify that the OPAC displays B&T content correctly, when BakerTaylorEnabled (staff side) is turned off.

When I try to access the opac-user page I am met with an error:

Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 1397: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 127

It looks like there is a stray [% END %] in the template logic.

Created attachment 142193 [details] [review]
Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC

This patch updates the system preferences controlling Baker & Taylor
content so that there are separate preferences for the OPAC and the
staff interface. The patch also adds Baker & Taylor cover images to the
staff client.

To test, apply the patch and run the database update.

- Go to Admnistration -> System preferences -> Enhanced content
- You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled
  preference. The OPACBakerTaylorEnabled should have the same setting
  you previously had for BakerTaylorEnabled. The BakerTaylorEnabled
  preference should be turned off.
  - Note that the description of the preferences have been updated to
    include links to the Baker & Taylor username and password
    preferences.
- Enable both and make sure you have a valid Baker & Taylor username
  and password entered.
- Perform a search in both the OPAC and staff interface. A Baker &
  Taylor cover image should appear on the bibliographic detail page in
  the OPAC, and on the search results and bibliographic detail page in
  the staff interface.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Created attachment 142194 [details] [review]
Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled

This patch adds a missing check for the BakerTaylorEnabled system
preference in staff interface search results.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Created attachment 142195 [details] [review]
Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled

This patch adds the new OPACBakerTaylorEnabled preferences to OPAC
templates and scripts which were missed in the first patch. The patch
also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.

Check these pages in the OPAC:

 - Catalog -> Search results
   - And search results -> RSS
 - Catalog -> Bibliographic details page -> Shelf browser
 - Catalog -> Lists -> List contents
 - Catalog -> Recent comments
   - And recent comments -> RSS
 - Your summary -> Checkouts and Overdues

(In reply to Owen Leonard from comment #27)
> Created attachment 142195 [details] [review] [review]
> Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled
> 
> This patch adds the new OPACBakerTaylorEnabled preferences to OPAC
> templates and scripts which were missed in the first patch. The patch
> also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.
> 
> Check these pages in the OPAC:
> 
>  - Catalog -> Search results
>    - And search results -> RSS
>  - Catalog -> Bibliographic details page -> Shelf browser
>  - Catalog -> Lists -> List contents
>  - Catalog -> Recent comments
>    - And recent comments -> RSS
>  - Your summary -> Checkouts and Overdues

Works as expected on all the above pages except for search results -> RSS and recent comments ->RSS. This is my first time using a sandbox, so I'm not sure if I'm doing something wrong or not. It seems to me that the link for the RSS is not being directed back to the sandbox opac. Instead of https://staff-coverimages.sandbox.bywatersolutions.com/cgi-bin/koha/members/member.pl?quicksearch=1&circsearch=1&searchmember=shakespeare, it has http://coverimages.mydnsname.org:8080/cgi-bin/koha/opac-search.pl?idx=kw&q=shakespeare&format=rss.

(In reply to Juliet Heltibridle from comment #28)
> (In reply to Owen Leonard from comment #27)
> > Created attachment 142195 [details] [review] [review] [review]
> > Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled
> > 
> > This patch adds the new OPACBakerTaylorEnabled preferences to OPAC
> > templates and scripts which were missed in the first patch. The patch
> > also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.
> > 
> > Check these pages in the OPAC:
> > 
> >  - Catalog -> Search results
> >    - And search results -> RSS
> >  - Catalog -> Bibliographic details page -> Shelf browser
> >  - Catalog -> Lists -> List contents
> >  - Catalog -> Recent comments
> >    - And recent comments -> RSS
> >  - Your summary -> Checkouts and Overdues
> 
> Works as expected on all the above pages except for search results -> RSS
> and recent comments ->RSS. This is my first time using a sandbox, so I'm not
> sure if I'm doing something wrong or not. It seems to me that the link for
> the RSS is not being directed back to the sandbox opac. Instead of
> https://staff-coverimages.sandbox.bywatersolutions.com/cgi-bin/koha/members/
> member.pl?quicksearch=1&circsearch=1&searchmember=shakespeare, it has
> http://coverimages.mydnsname.org:8080/cgi-bin/koha/opac-search.
> pl?idx=kw&q=shakespeare&format=rss.

Hi Juliet, the RSS will build the link from the OpacBaseURL system preference setting, if you correct that, it might work ok. Could you give it another go maybe?

Thank you Katrin. I updated the system preference. Cover images show correctly on the Comments RSS as well. But I get the following error when clicking on the RSS feed for a search results page: 
Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127

(In reply to Juliet Heltibridle from comment #30)
> Thank you Katrin. I updated the system preference. Cover images show
> correctly on the Comments RSS as well. But I get the following error when
> clicking on the RSS feed for a search results page: 
> Template process failed: file error - biblio_a_href: not found at
> /kohadevbox/koha/C4/Templates.pm line 127

It might be unrelated to this patch set. It looks like a missing include (I recently had a similar error elsewhere) Owen, do you want to follow-up?

(In reply to Juliet Heltibridle from comment #30)
> But I get the following error when
> clicking on the RSS feed for a search results page: 
> Template process failed: file error - biblio_a_href: not found at
> /kohadevbox/koha/C4/Templates.pm line 127

This bug is in master too. I have submitted a fix on Bug 32114.

(In reply to Owen Leonard from comment #27)
> Created attachment 142195 [details] [review] [review]
> Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled
> 
> This patch adds the new OPACBakerTaylorEnabled preferences to OPAC
> templates and scripts which were missed in the first patch. The patch
> also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.
> 
> Check these pages in the OPAC:
> 
>  - Catalog -> Search results
>    - And search results -> RSS
>  - Catalog -> Bibliographic details page -> Shelf browser
>  - Catalog -> Lists -> List contents
>  - Catalog -> Recent comments
>    - And recent comments -> RSS
>  - Your summary -> Checkouts and Overdues

Cover images display in search results, bibligraphic details page, recent comments, recent comments RSS, and lists (both public & private), and summary checkouts and overdues.

Cover images are still not displaying on the search results -> RSS feed.

Additionally, cover images from Baker & Taylor do not display on the bibliographic details page on the staff intranet.

Just bumping this - it is still an issue in 24.05

Fayetteville Public Library supports this bug.  Would help our staff have consistency with what patrons and staff are seeing.

Created attachment 169061 [details] [review]
Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC

This patch updates the system preferences controlling Baker & Taylor
content so that there are separate preferences for the OPAC and the
staff interface. The patch also adds Baker & Taylor cover images to the
staff client.

To test, apply the patch and run the database update.

- Go to Admnistration -> System preferences -> Enhanced content
- You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled
  preference. The OPACBakerTaylorEnabled should have the same setting
  you previously had for BakerTaylorEnabled. The BakerTaylorEnabled
  preference should be turned off.
  - Note that the description of the preferences have been updated to
    include links to the Baker & Taylor username and password
    preferences.
- Enable both and make sure you have a valid Baker & Taylor username
  and password entered.
- Perform a search in both the OPAC and staff interface. A Baker &
  Taylor cover image should appear on the bibliographic detail page in
  the OPAC, and on the search results and bibliographic detail page in
  the staff interface.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Created attachment 169062 [details] [review]
Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled

This patch adds a missing check for the BakerTaylorEnabled system
preference in staff interface search results.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Created attachment 169063 [details] [review]
Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled

This patch adds the new OPACBakerTaylorEnabled preferences to OPAC
templates and scripts which were missed in the first patch. The patch
also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.

Check these pages in the OPAC:

 - Catalog -> Search results
   - And search results -> RSS
 - Catalog -> Bibliographic details page -> Shelf browser
 - Catalog -> Lists -> List contents
 - Catalog -> Recent comments
   - And recent comments -> RSS
 - Your summary -> Checkouts and Overdues