Bug 32139

Summary: "Update on login" setting not set when creating domain from new IdP page
Product: Koha Reporter: David Cook <dcook>
Component: AuthenticationAssignee: David Cook <dcook>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: dpavlin, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Bug Depends on: 31378    
Bug Blocks:    
Attachments: Bug 32139: Set "update on login" correctly when creating new IdP
Bug 32139: Set "update on login" correctly when creating new IdP

Description David Cook 2022-11-08 23:59:38 UTC
When you're creating a new Identity Provider, you're prompted to create a domain. 

All the settings are saved correctly except "Update on login". It will be set to "No" even when you select "Yes"
Comment 1 David Cook 2022-11-09 02:03:41 UTC
Created attachment 143454 [details] [review]
Bug 32139: Set "update on login" correctly when creating new IdP

This patches allows "Update on Login" to be set to "Yes" when
creating a domain as part of a new Identity Provider.

Test plan:
1) Apply patch
2) koha-plack --reload kohadev
3) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl
4) Click "New identity provider"
5) Fill in "Code" and "Description" with "test"
6) Click "Add default OAuth configuration"
7) Click "Add default OAUth mapping"
8) Fill in "Domain" with "*"
9) Change "Allow OPAC", "Allow staff", "Auto register", and "Update on login"
to "Yes"
10) Click "Submit"
11) Click "Manage Domains" for your new Identity Provider
12) Note that "Allow opac", "Allow staff", "Auto register", and "Update on login"
are all set to "Yes"
Comment 2 Tomás Cohen Arazi (tcohen) 2022-11-09 16:33:40 UTC
Created attachment 143523 [details] [review]
Bug 32139: Set "update on login" correctly when creating new IdP

This patches allows "Update on Login" to be set to "Yes" when
creating a domain as part of a new Identity Provider.

Test plan:
1) Apply patch
2) koha-plack --reload kohadev
3) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl
4) Click "New identity provider"
5) Fill in "Code" and "Description" with "test"
6) Click "Add default OAuth configuration"
7) Click "Add default OAUth mapping"
8) Fill in "Domain" with "*"
9) Change "Allow OPAC", "Allow staff", "Auto register", and "Update on login"
to "Yes"
10) Click "Submit"
11) Click "Manage Domains" for your new Identity Provider
12) Note that "Allow opac", "Allow staff", "Auto register", and "Update on login"
are all set to "Yes"

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi (tcohen) 2022-11-09 17:40:29 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!