When you're creating a new Identity Provider, you're prompted to create a domain. All the settings are saved correctly except "Update on login". It will be set to "No" even when you select "Yes"
Created attachment 143454 [details] [review] Bug 32139: Set "update on login" correctly when creating new IdP This patches allows "Update on Login" to be set to "Yes" when creating a domain as part of a new Identity Provider. Test plan: 1) Apply patch 2) koha-plack --reload kohadev 3) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl 4) Click "New identity provider" 5) Fill in "Code" and "Description" with "test" 6) Click "Add default OAuth configuration" 7) Click "Add default OAUth mapping" 8) Fill in "Domain" with "*" 9) Change "Allow OPAC", "Allow staff", "Auto register", and "Update on login" to "Yes" 10) Click "Submit" 11) Click "Manage Domains" for your new Identity Provider 12) Note that "Allow opac", "Allow staff", "Auto register", and "Update on login" are all set to "Yes"
Created attachment 143523 [details] [review] Bug 32139: Set "update on login" correctly when creating new IdP This patches allows "Update on Login" to be set to "Yes" when creating a domain as part of a new Identity Provider. Test plan: 1) Apply patch 2) koha-plack --reload kohadev 3) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl 4) Click "New identity provider" 5) Fill in "Code" and "Description" with "test" 6) Click "Add default OAuth configuration" 7) Click "Add default OAUth mapping" 8) Fill in "Domain" with "*" 9) Change "Allow OPAC", "Allow staff", "Auto register", and "Update on login" to "Yes" 10) Click "Submit" 11) Click "Manage Domains" for your new Identity Provider 12) Note that "Allow opac", "Allow staff", "Auto register", and "Update on login" are all set to "Yes" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!