Bug 32163

Summary: ErmUserRole has wrong koha_object[s]_class
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: martin.renvoize, pedro.amorim
Version: unspecifiedKeywords: rel_22_11_candidate
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Bug Depends on: 32030, 32154, 32161    
Bug Blocks:    
Attachments: Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole

Description Jonathan Druart 2022-11-10 07:14:51 UTC

    
Comment 1 Jonathan Druart 2022-11-10 07:17:17 UTC
Created attachment 143623 [details] [review]
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however
Comment 2 Pedro Amorim 2022-11-10 18:22:12 UTC
This also requires bug 32161.
With this patch (and the previous ones it depends on) all tests from TestBuidler.t are successful.
Comment 3 Pedro Amorim 2022-11-10 18:25:35 UTC
Created attachment 143701 [details] [review]
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2022-11-11 11:19:09 UTC
Created attachment 143774 [details] [review]
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2022-11-11 11:19:36 UTC
Another trivial correction, thanks for the quick follow-ups chaps.

Passing QA
Comment 6 Tomás Cohen Arazi (tcohen) 2022-11-11 12:03:27 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!