Bug 32163 - ErmUserRole has wrong koha_object[s]_class
Summary: ErmUserRole has wrong koha_object[s]_class
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords: rel_22_11_candidate
Depends on: 32030 32154 32161
Blocks:
  Show dependency tree / graph
 
Reported: 2022-11-10 07:14 UTC by Jonathan Druart
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole (1.01 KB, patch)
2022-11-10 07:17 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole (1.06 KB, patch)
2022-11-10 18:25 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole (1.13 KB, patch)
2022-11-11 11:19 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-10 07:14:51 UTC 

    


    


      



        
          Comment 1
        

        
          Jonathan Druart

        

        
        

        
          2022-11-10 07:17:17 UTC
        

      






Created attachment 143623 [details] [review]
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

    


    


      



        
          Comment 2
        

        
          Pedro Amorim

        

        
        

        
          2022-11-10 18:22:12 UTC
        

      






This also requires bug 32161.
With this patch (and the previous ones it depends on) all tests from TestBuidler.t are successful.

    


    


      



        
          Comment 3
        

        
          Pedro Amorim

        

        
        

        
          2022-11-10 18:25:35 UTC
        

      






Created attachment 143701 [details] [review]
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

    


    


      



        
          Comment 4
        

        
          Martin Renvoize (ashimema)

        

        
        

        
          2022-11-11 11:19:09 UTC
        

      






Created attachment 143774 [details] [review]
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

    


    


      



        
          Comment 5
        

        
          Martin Renvoize (ashimema)

        

        
        

        
          2022-11-11 11:19:36 UTC
        

      






Another trivial correction, thanks for the quick follow-ups chaps.

Passing QA

    


    


      



        
          Comment 6
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2022-11-11 12:03:27 UTC
        

      






Pushed to master for 22.11.

Nice work everyone, thanks!