Summary: | Order prices not populated when adding to a basket from a staged file | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | major | ||
Priority: | P5 - low | CC: | andrewfh, lucas |
Version: | Main | Keywords: | rel_22_05_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Bug Depends on: | 29955, 32166 | ||
Bug Blocks: | |||
Attachments: |
Bug 32171: Store after populating order
Bug 32171: Store after populating order Bug 32171: Store after populating order Bug 32171: Store after populating order |
Description
Nick Clemens (kidclamp)
2022-11-10 20:22:05 UTC
Created attachment 143707 [details] [review] Bug 32171: Store after populating order This updates the call to store after populating the order I put this on it's own bug just for sake of dependency, in case it is needed seperate from 32166 for backports To test: 1 - Apply and test with bug 32166 Looks like you forgot to declare your oder: Could not compile /kohadevbox/koha/acqui/addorderiso2709.pl: Global symbol "$oder" requires explicit package name (did you forget to declare "my $oder"?) at /kohadevbox/koha/acqui/addorderiso2709.pl line 297. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/acqui/addorderiso2709.pl line 754. Created attachment 143901 [details] [review] Bug 32171: Store after populating order This updates the call to store after populating the order I put this on it's own bug just for sake of dependency, in case it is needed seperate from 32166 for backports To test: 1 - Apply and test with bug 32166 Created attachment 143919 [details] [review] Bug 32171: Store after populating order This updates the call to store after populating the order I put this on it's own bug just for sake of dependency, in case it is needed seperate from 32166 for backports To test: 1 - Apply and test with bug 32166 Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> coopted the test plan from 32166: To test: -1: apply patch 0 - Set system preferences: MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l 1 - Stage attached sample file, Format:MARCXML, Record matching:Koha biblio 999$c 2 - Add to a basket from the staged file 3 - Select 1st record to basket and save 4 - Record is added with the fields above as expected AND THE PRICE FIELDS ARE POPULATED 5- repeat with the other records if you feel like it Created attachment 143954 [details] [review] Bug 32171: Store after populating order This updates the call to store after populating the order I put this on it's own bug just for sake of dependency, in case it is needed seperate from 32166 for backports To test: 1 - Apply and test with bug 32166 Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx for the help with the test plan, Andrew! Pushed to master for 22.11. Nice work everyone, thanks! |