Bug 29955 - Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 21204 29959
  Show dependency treegraph
 
Reported: 2022-01-27 10:10 UTC by Julian Maurice
Modified: 2022-07-16 22:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 29955: Move populate_order_with_prices to Koha namespace (71.94 KB, patch)
2022-01-27 10:11 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 29955: Move populate_order_with_prices to Koha namespace (72.08 KB, patch)
2022-05-28 10:27 UTC, Joonas Kylmälä
Details | Diff | Splinter Review
Bug 29955: Move populate_order_with_prices to Koha namespace (72.07 KB, patch)
2022-07-16 22:06 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2022-01-27 10:10:44 UTC

    
Comment 1 Julian Maurice 2022-01-27 10:11:39 UTC
Created attachment 129856 [details] [review]
Bug 29955: Move populate_order_with_prices to Koha namespace

and split the subroutine into 2 smaller subroutines (one for ordering,
the other for receiving)

Test plan:
1. Create a vendor and an acquisition basket
2. In this basket, create new orders using all the different methods
   (from an existing record, from a suggestion, from a new record, ...)
   then close the basket and receive these orders.
   Make sure it works the same with and without the patch
3. Run tests in t/Prices.t,
   t/db_dependent/Acquisition/populate_order_with_prices.t, and
   t/db_dependent/Budgets.t
Comment 2 Joonas Kylmälä 2022-05-28 10:27:03 UTC
Created attachment 135436 [details] [review]
Bug 29955: Move populate_order_with_prices to Koha namespace

and split the subroutine into 2 smaller subroutines (one for ordering,
the other for receiving)

Test plan:
1. Create a vendor and an acquisition basket
2. In this basket, create new orders using all the different methods
   (from an existing record, from a suggestion, from a new record, ...)
   then close the basket and receive these orders.
   Make sure it works the same with and without the patch
3. Run tests in t/Prices.t,
   t/db_dependent/Acquisition/populate_order_with_prices.t, and
   t/db_dependent/Budgets.t

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Comment 3 Victor Grousset/tuxayo 2022-07-16 22:06:58 UTC
Created attachment 137797 [details] [review]
Bug 29955: Move populate_order_with_prices to Koha namespace

and split the subroutine into 2 smaller subroutines (one for ordering,
the other for receiving)

Test plan:
1. Create a vendor and an acquisition basket
2. In this basket, create new orders using all the different methods
   (from an existing record, from a suggestion, from a new record, ...)
   then close the basket and receive these orders.
   Make sure it works the same with and without the patch
3. Run tests in t/Prices.t,
   t/db_dependent/Acquisition/populate_order_with_prices.t, and
   t/db_dependent/Budgets.t

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Comment 4 Victor Grousset/tuxayo 2022-07-16 22:07:16 UTC
Rebased