| Summary: | ERM is missing page-sections | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Templates | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
22.11.00
|
Circulation function: | |
| Bug Depends on: | 30952, 32030 | ||
| Bug Blocks: | 31757 | ||
| Attachments: |
Bug 32179: Add page-sections as appropraite to the ERM module
Bug 32179: Add page-sections as appropraite to the ERM module Bug 32179: Add page-sections as appropraite to the ERM module |
||
|
Description
Martin Renvoize (ashimema)
2022-11-11 14:29:36 UTC
Created attachment 143791 [details] [review] Bug 32179: Add page-sections as appropraite to the ERM module We missed the page-section addition when ERM was updated for the new UI prior to push. Test plan 1) Start a koha-testing-docker 2) Build the ERM module with 'kshell > yarn install > yarn build_js' 3) Enable the ERM module via the system preferences 4) Enable both 'EBSCO' and 'Local' as providers 4) Check the following pages * ERM > Agreements * ERM > Licenses * ERM > eHoldings > Local > Packages * ERM > eHoldings > Local > Titles * ERM > eHoldings > Local > Titles > Add from a list * ERM > eHoldings > EBSCO > Packages * ERM > eHoldings > EBSCO > Titles 5) Apply this patch 6) Build the app again 'yarn build_js' 7) Confirm page-sections appear as expected on the pages mentioned in step 4. Created attachment 143793 [details] [review] Bug 32179: Add page-sections as appropraite to the ERM module We missed the page-section addition when ERM was updated for the new UI prior to push. Test plan 1) Start a koha-testing-docker 2) Build the ERM module with 'kshell > yarn install > yarn build_js' 3) Enable the ERM module via the system preferences 4) Enable both 'EBSCO' and 'Local' as providers 4) Check the following pages * ERM > Agreements * ERM > Licenses * ERM > eHoldings > Local > Packages * ERM > eHoldings > Local > Titles * ERM > eHoldings > Local > Titles > Add from a list * ERM > eHoldings > EBSCO > Packages * ERM > eHoldings > EBSCO > Titles 5) Apply this patch 6) Build the app again 'yarn build_js' 7) Confirm page-sections appear as expected on the pages mentioned in step 4. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: Run prettier Created attachment 143801 [details] [review] Bug 32179: Add page-sections as appropraite to the ERM module We missed the page-section addition when ERM was updated for the new UI prior to push. Test plan 1) Start a koha-testing-docker 2) Build the ERM module with 'kshell > yarn install > yarn build_js' 3) Enable the ERM module via the system preferences 4) Enable both 'EBSCO' and 'Local' as providers 4) Check the following pages * ERM > Agreements * ERM > Licenses * ERM > eHoldings > Local > Packages * ERM > eHoldings > Local > Titles * ERM > eHoldings > Local > Titles > Add from a list * ERM > eHoldings > EBSCO > Packages * ERM > eHoldings > EBSCO > Titles 5) Apply this patch 6) Build the app again 'yarn build_js' 7) Confirm page-sections appear as expected on the pages mentioned in step 4. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Minor rebase (and now I have the prettier git hook :) ) Pushed to master for 22.11. Nice work everyone, thanks! |