The newly added ERM module is missing appropraite page-section containers. This is required to improve contrast in table row highlighting and brings more consistency to our UI.
Created attachment 143791 [details] [review] Bug 32179: Add page-sections as appropraite to the ERM module We missed the page-section addition when ERM was updated for the new UI prior to push. Test plan 1) Start a koha-testing-docker 2) Build the ERM module with 'kshell > yarn install > yarn build_js' 3) Enable the ERM module via the system preferences 4) Enable both 'EBSCO' and 'Local' as providers 4) Check the following pages * ERM > Agreements * ERM > Licenses * ERM > eHoldings > Local > Packages * ERM > eHoldings > Local > Titles * ERM > eHoldings > Local > Titles > Add from a list * ERM > eHoldings > EBSCO > Packages * ERM > eHoldings > EBSCO > Titles 5) Apply this patch 6) Build the app again 'yarn build_js' 7) Confirm page-sections appear as expected on the pages mentioned in step 4.
Created attachment 143793 [details] [review] Bug 32179: Add page-sections as appropraite to the ERM module We missed the page-section addition when ERM was updated for the new UI prior to push. Test plan 1) Start a koha-testing-docker 2) Build the ERM module with 'kshell > yarn install > yarn build_js' 3) Enable the ERM module via the system preferences 4) Enable both 'EBSCO' and 'Local' as providers 4) Check the following pages * ERM > Agreements * ERM > Licenses * ERM > eHoldings > Local > Packages * ERM > eHoldings > Local > Titles * ERM > eHoldings > Local > Titles > Add from a list * ERM > eHoldings > EBSCO > Packages * ERM > eHoldings > EBSCO > Titles 5) Apply this patch 6) Build the app again 'yarn build_js' 7) Confirm page-sections appear as expected on the pages mentioned in step 4. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: Run prettier
Created attachment 143801 [details] [review] Bug 32179: Add page-sections as appropraite to the ERM module We missed the page-section addition when ERM was updated for the new UI prior to push. Test plan 1) Start a koha-testing-docker 2) Build the ERM module with 'kshell > yarn install > yarn build_js' 3) Enable the ERM module via the system preferences 4) Enable both 'EBSCO' and 'Local' as providers 4) Check the following pages * ERM > Agreements * ERM > Licenses * ERM > eHoldings > Local > Packages * ERM > eHoldings > Local > Titles * ERM > eHoldings > Local > Titles > Add from a list * ERM > eHoldings > EBSCO > Packages * ERM > eHoldings > EBSCO > Titles 5) Apply this patch 6) Build the app again 'yarn build_js' 7) Confirm page-sections appear as expected on the pages mentioned in step 4. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Minor rebase (and now I have the prettier git hook :) )
Pushed to master for 22.11. Nice work everyone, thanks!