Bug 32179 - ERM is missing page-sections
Summary: ERM is missing page-sections
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952 32030
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-11-11 14:29 UTC by Martin Renvoize
Modified: 2023-06-08 22:29 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32179: Add page-sections as appropraite to the ERM module (6.89 KB, patch)
2022-11-11 14:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32179: Add page-sections as appropraite to the ERM module (7.14 KB, patch)
2022-11-11 15:36 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32179: Add page-sections as appropraite to the ERM module (7.16 KB, patch)
2022-11-12 08:10 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-11-11 14:29:36 UTC
The newly added ERM module is missing appropraite page-section containers. This is required to improve contrast in table row highlighting and brings more consistency to our UI.
Comment 1 Martin Renvoize 2022-11-11 14:47:34 UTC
Created attachment 143791 [details] [review]
Bug 32179: Add page-sections as appropraite to the ERM module

We missed the page-section addition when ERM was updated for the new UI
prior to push.

Test plan
1) Start a koha-testing-docker
2) Build the ERM module with 'kshell > yarn install > yarn build_js'
3) Enable the ERM module via the system preferences
4) Enable both 'EBSCO' and 'Local' as providers
4) Check the following pages
   * ERM > Agreements
   * ERM > Licenses
   * ERM > eHoldings > Local > Packages
   * ERM > eHoldings > Local > Titles
   * ERM > eHoldings > Local > Titles > Add from a list
   * ERM > eHoldings > EBSCO > Packages
   * ERM > eHoldings > EBSCO > Titles
5) Apply this patch
6) Build the app again 'yarn build_js'
7) Confirm page-sections appear as expected on the pages mentioned in
   step 4.
Comment 2 Jonathan Druart 2022-11-11 15:36:30 UTC
Created attachment 143793 [details] [review]
Bug 32179: Add page-sections as appropraite to the ERM module

We missed the page-section addition when ERM was updated for the new UI
prior to push.

Test plan
1) Start a koha-testing-docker
2) Build the ERM module with 'kshell > yarn install > yarn build_js'
3) Enable the ERM module via the system preferences
4) Enable both 'EBSCO' and 'Local' as providers
4) Check the following pages
   * ERM > Agreements
   * ERM > Licenses
   * ERM > eHoldings > Local > Packages
   * ERM > eHoldings > Local > Titles
   * ERM > eHoldings > Local > Titles > Add from a list
   * ERM > eHoldings > EBSCO > Packages
   * ERM > eHoldings > EBSCO > Titles
5) Apply this patch
6) Build the app again 'yarn build_js'
7) Confirm page-sections appear as expected on the pages mentioned in
   step 4.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: Run prettier
Comment 3 Martin Renvoize 2022-11-12 08:10:11 UTC
Created attachment 143801 [details] [review]
Bug 32179: Add page-sections as appropraite to the ERM module

We missed the page-section addition when ERM was updated for the new UI
prior to push.

Test plan
1) Start a koha-testing-docker
2) Build the ERM module with 'kshell > yarn install > yarn build_js'
3) Enable the ERM module via the system preferences
4) Enable both 'EBSCO' and 'Local' as providers
4) Check the following pages
   * ERM > Agreements
   * ERM > Licenses
   * ERM > eHoldings > Local > Packages
   * ERM > eHoldings > Local > Titles
   * ERM > eHoldings > Local > Titles > Add from a list
   * ERM > eHoldings > EBSCO > Packages
   * ERM > eHoldings > EBSCO > Titles
5) Apply this patch
6) Build the app again 'yarn build_js'
7) Confirm page-sections appear as expected on the pages mentioned in
   step 4.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Martin Renvoize 2022-11-12 08:11:11 UTC
Minor rebase (and now I have the prettier git hook :) )
Comment 5 Tomás Cohen Arazi 2022-11-14 12:22:33 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!