Bug 32181

Summary: ERM - Cannot filter by expired when adding an agreement to EBSCO's package
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ERMAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: amit.gupta, amitddng135, jonathan.druart, jonathan.field, martin.renvoize, pedro.amorim, pjamorim91, tomascohen
Version: unspecifiedKeywords: rel_22_11_candidate
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 32030    
Bug Blocks:    
Attachments: Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's package
Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's package

Description Jonathan Druart 2022-11-11 15:30:53 UTC

    
Comment 1 Jonathan Druart 2022-11-11 15:34:25 UTC
Created attachment 143792 [details] [review]
Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's package

We shouldn't change the current route (which will lead to change the
view) when we are adding an agreement to a EBSCO's package

Test plan:
Go to E-Resource management / eHoldings / EBSCO / Packages
Search for a package, select one
Click "Add new agreement"
Use the "Filter by expired" filter
=> Without this patch you are redirected to the package list view
=> With this patch applied the table is filtered as expected
Comment 2 Tomás Cohen Arazi 2022-11-14 18:20:18 UTC
Created attachment 143855 [details] [review]
Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's package

We shouldn't change the current route (which will lead to change the
view) when we are adding an agreement to a EBSCO's package

Test plan:
Go to E-Resource management / eHoldings / EBSCO / Packages
Search for a package, select one
Click "Add new agreement"
Use the "Filter by expired" filter
=> Without this patch you are redirected to the package list view
=> With this patch applied the table is filtered as expected

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi 2022-11-17 18:04:46 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!