Bug 32181 - ERM - Cannot filter by expired when adding an agreement to EBSCO's package
Summary: ERM - Cannot filter by expired when adding an agreement to EBSCO's package
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords: rel_22_11_candidate
Depends on: 32030
Blocks:
  Show dependency tree / graph
 
Reported: 2022-11-11 15:30 UTC by Jonathan Druart
Modified: 2023-06-08 22:28 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's package (1.86 KB, patch)
2022-11-11 15:34 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's package (1.92 KB, patch)
2022-11-14 18:20 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-11 15:30:53 UTC 

    


    


      



        
          Comment 1
        

        
          Jonathan Druart

        

        
        

        
          2022-11-11 15:34:25 UTC
        

      






Created attachment 143792 [details] [review]
Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's package

We shouldn't change the current route (which will lead to change the
view) when we are adding an agreement to a EBSCO's package

Test plan:
Go to E-Resource management / eHoldings / EBSCO / Packages
Search for a package, select one
Click "Add new agreement"
Use the "Filter by expired" filter
=> Without this patch you are redirected to the package list view
=> With this patch applied the table is filtered as expected

    


    


      



        
          Comment 2
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2022-11-14 18:20:18 UTC
        

      






Created attachment 143855 [details] [review]
Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's package

We shouldn't change the current route (which will lead to change the
view) when we are adding an agreement to a EBSCO's package

Test plan:
Go to E-Resource management / eHoldings / EBSCO / Packages
Search for a package, select one
Click "Add new agreement"
Use the "Filter by expired" filter
=> Without this patch you are redirected to the package list view
=> With this patch applied the table is filtered as expected

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

    


    


      



        
          Comment 3
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2022-11-17 18:04:46 UTC
        

      






Pushed to master for 22.11.

Nice work everyone, thanks!