Bug 32267

Summary: Koha/ERM/Agreements.t is failing
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: pjamorim91, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Bug Depends on: 32154    
Bug Blocks:    
Attachments: Bug 32267: (bug 32154 follow-up) Fix Agreements.t
Bug 32267: (bug 32154 follow-up) Fix Agreements.t

Description Jonathan Druart 2022-11-18 13:16:36 UTC
#   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 109.                                         #     Structures begin differing at:                                                                  
    #          $got->[0]{user_role_id} = '1'                                                              
    #     $expected->[0]{user_role_id} = Does not exist                                                   
    # Looks like you failed 1 test of 4.
Comment 1 Jonathan Druart 2022-11-18 13:18:05 UTC
Created attachment 144062 [details] [review]
Bug 32267: (bug 32154 follow-up) Fix Agreements.t

#   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 111.
    #     Structures begin differing at:
    #          $got->[0]{user_role_id} = '2'
    #     $expected->[0]{user_role_id} = Does not exist
    # Looks like you failed 1 test of 4.

Another fix may be better, please suggest if you disagree
Comment 2 Tomás Cohen Arazi (tcohen) 2022-11-18 13:54:16 UTC
Created attachment 144064 [details] [review]
Bug 32267: (bug 32154 follow-up) Fix Agreements.t

#   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 111.
    #     Structures begin differing at:
    #          $got->[0]{user_role_id} = '2'
    #     $expected->[0]{user_role_id} = Does not exist
    # Looks like you failed 1 test of 4.

Another fix may be better, please suggest if you disagree

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi (tcohen) 2022-11-18 15:08:14 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!