Bug 32268

Summary: t/db_dependent/XSLT.t is failing randomly
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: tomascohen
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Bug Depends on: 19532    
Bug Blocks: 25551    
Attachments: Bug 32268: Prevent XSLT.t to fail randomly
Bug 32268: Prevent XSLT.t to fail randomly

Description Jonathan Druart 2022-11-18 13:39:07 UTC

    
Comment 1 Jonathan Druart 2022-11-18 13:43:31 UTC
Created attachment 144063 [details] [review]
Bug 32268: Prevent XSLT.t to fail randomly

Can't call method "itemnumber" on an undefined value at /kohadevbox/koha/Koha/Recall.pm line 343.

We should set item_level and not let TestBuilder pick a value.

This may have been caught (make it more obvious) by the recent change to
TestBuilder for boolean (Bug 32030: fix test builder for boolean)
Comment 2 Tomás Cohen Arazi (tcohen) 2022-11-18 14:25:49 UTC
Created attachment 144066 [details] [review]
Bug 32268: Prevent XSLT.t to fail randomly

Can't call method "itemnumber" on an undefined value at /kohadevbox/koha/Koha/Recall.pm line 343.

We should set item_level and not let TestBuilder pick a value.

This may have been caught (make it more obvious) by the recent change to
TestBuilder for boolean (Bug 32030: fix test builder for boolean)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi (tcohen) 2022-11-18 15:08:20 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!