Summary: | Last borrower and previous borrower display on moredetail.pl is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, gmcharlt, jonathan.druart, lucas, m.de.rooy, michael.hafen |
Version: | Main | Keywords: | regression, rel_22_11_candidate |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.05.00,22.11.02
|
Circulation function: | |
Bug Depends on: | 31315 | ||
Bug Blocks: | 33788 | ||
Attachments: |
Bug 32272: Restore last and previous borrowers on moredetail
Bug 32272: Restore last and previous borrowers on moredetail Bug 32272: Restore last and previous borrowers on moredetail Bug 32272: Restore last and previous borrowers on moredetail Bug 32272: Restore last and previous borrowers on moredetail |
Description
Nick Clemens (kidclamp)
2022-11-18 15:44:50 UTC
What's your opinion on this? I don't mind reintroducing the "feature", but there is something inconsistent: We are displaying "Last returned by" if StoreLastBorrower is set, but then display the last 3 patrons who borrowed the items whatever is the value of StoreLastBorrower. Created attachment 144107 [details] [review] Bug 32272: Restore last and previous borrowers on moredetail GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of the last 3 borrowers. But 31315 forgot to adjust the code when it has been moved to using Koha::Items Test plan: Check an item in and out to several patrons Go to the moredetail page (items) and confirm that the "last borrowers" info is displayed Marking as 22.11 candidate but could be for .01 (In reply to Jonathan Druart from comment #1) > What's your opinion on this? > > I don't mind reintroducing the "feature", but there is something > inconsistent: We are displaying "Last returned by" if StoreLastBorrower is > set, but then display the last 3 patrons who borrowed the items whatever is > the value of StoreLastBorrower. Yeah, those are two parallel but distinct systems with some confusing labels. Both are meaningful and needed. Patch doesn't apply: Applying: Bug 32272: Restore last and previous borrowers on moredetail Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 32272: Restore last and previous borrowers on moredetail [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-32272-Restore-last-and-previous-borrowers-on-m-ilGOtR.patch Apply? [(y)es, (n)o, (i)nteractive] Created attachment 145107 [details] [review] Bug 32272: Restore last and previous borrowers on moredetail GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of the last 3 borrowers. But 31315 forgot to adjust the code when it has been moved to using Koha::Items Test plan: Check an item in and out to several patrons Go to the moredetail page (items) and confirm that the "last borrowers" info is displayed [Rebase 2023-01-06] Created attachment 145156 [details] [review] Bug 32272: Restore last and previous borrowers on moredetail GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of the last 3 borrowers. But 31315 forgot to adjust the code when it has been moved to using Koha::Items Test plan: Check an item in and out to several patrons Go to the moredetail page (items) and confirm that the "last borrowers" info is displayed Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Michael: Normally a rebase does not imply an author change? Created attachment 145255 [details] [review] Bug 32272: Restore last and previous borrowers on moredetail GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of the last 3 borrowers. But 31315 forgot to adjust the code when it has been moved to using Koha::Items Test plan: Check an item in and out to several patrons Go to the moredetail page (items) and confirm that the "last borrowers" info is displayed Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 145258 [details] [review] Bug 32272: Restore last and previous borrowers on moredetail GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of the last 3 borrowers. But 31315 forgot to adjust the code when it has been moved to using Koha::Items Test plan: Check an item in and out to several patrons Go to the moredetail page (items) and confirm that the "last borrowers" info is displayed Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Restored date and author. Nice work everyone! Pushed to 23.05.x for the next release Nice work, thanks everyone! Pushed to 22.11.x for the next release. Missing dependencies for 22.05.x, no backport. |