| Summary: | Syndetics links are built wrong on the staff results page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Tools | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | arthur.suzuki, sbcornell |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.01,22.05.09
|
|
| Circulation function: | |||
| Bug Depends on: | 21225 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 32389: Fix Syndetics link on staff results page
Bug 32389: Fix Syndetics link on staff results page Bug 32389: Fix Syndetics link on staff results page |
||
|
Description
Lucas Gass (lukeg)
2022-12-01 17:33:35 UTC
We are attempting to pass in this template variable: [% DetailPage | url %] I can't find this anywhere else in the codebase, so maybe we should just hardcode this bit? Created attachment 144383 [details] [review] Bug 32389: Fix Syndetics link on staff results page To test: 1. Have SyndeticsCoverImages on and Syndetics setup. 2. Do a search that will return some results with Syndetics images 3. Click on the image link and you will get a 404 4. Apply patch 5. Link works! Created attachment 144397 [details] [review] Bug 32389: Fix Syndetics link on staff results page To test: 1. Have SyndeticsCoverImages on and Syndetics setup. 2. Do a search that will return some results with Syndetics images 3. Click on the image link and you will get a 404 4. Apply patch 5. Link works! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed off based on the content of the patch even though I don't have Syndetics credentials to test live. I suspect the origin of this bug was some variation on handling the BiblioDefaultView system preference. Created attachment 144492 [details] [review] Bug 32389: Fix Syndetics link on staff results page To test: 1. Have SyndeticsCoverImages on and Syndetics setup. 2. Do a search that will return some results with Syndetics images 3. Click on the image link and you will get a 404 4. Apply patch 5. Link works! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to 22.11.x for the next release Is there any chance to get this on 22.05? We were looking forward to syndetics images on the staff side. Backported to 22.05.x for upcoming 22.05.09 release this one seems to depends on 21225 which was not released for 21.11.x. Won't backport |