Bug 32421

Summary: Add collection ( ccode ) column to holds to pull
Product: Koha Reporter: Lucas Gass <lucas>
Component: Hold requestsAssignee: Lucas Gass <lucas>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, Laura.escamilla, martin.renvoize, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This enhancement removes an inconsistency in the holds to pull display by adding collection code to the displayed columns.
Version(s) released in:
23.05.00,22.11.04
Attachments: Bug 32421: Add collection column to holds to pull
Bug 32421: (follow-up) Correct table settings
Bug 32421: (follow-up) Correct table settings
Bug 32421: Add collection column to holds to pull
Bug 32421: (follow-up) Correct table settings
Bug 32421: Add collection column to holds to pull

Description Lucas Gass 2022-12-07 18:40:14 UTC
Some libraries would find it helpful to include a column for collection to the holds to pull page.
Comment 1 Lucas Gass 2022-12-07 18:44:50 UTC
Created attachment 144486 [details] [review]
Bug 32421: Add collection column to holds to pull

To test:

1. Place some holds
2. Go to Circulation > Holds to pull
3. Notice there is not column to indicate collection ( CCODE )
4. Apply patch and restart services
5. Step 2 again, this time you should see a column for holds to pull
6. Using both the Columns button and via 'Table setting' attempt to hide the column and other columns. Ensure everything is being heiiden correctly.
Comment 2 Laura Escamilla 2022-12-08 12:57:06 UTC
Lucas, 

Everything works well except that there is no option to hide the collection column under "Table Setting", it is currently only available under the Columns button. 



(In reply to Lucas Gass from comment #1)
> Created attachment 144486 [details] [review] [review]
> Bug 32421: Add collection column to holds to pull
> 
> To test:
> 
> 1. Place some holds
> 2. Go to Circulation > Holds to pull
> 3. Notice there is not column to indicate collection ( CCODE )
> 4. Apply patch and restart services
> 5. Step 2 again, this time you should see a column for holds to pull
> 6. Using both the Columns button and via 'Table setting' attempt to hide the
> column and other columns. Ensure everything is being heiiden correctly.
Comment 3 Lucas Gass 2022-12-08 15:26:49 UTC
Created attachment 144500 [details] [review]
Bug 32421: (follow-up) Correct table settings
Comment 4 Lucas Gass 2022-12-08 15:27:32 UTC
> Everything works well except that there is no option to hide the collection
> column under "Table Setting", it is currently only available under the
> Columns button.

Laura, thanks for testing! I have made that correction.
Comment 5 ByWater Sandboxes 2022-12-08 15:44:24 UTC
Created attachment 144501 [details] [review]
Bug 32421: (follow-up) Correct table settings

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 6 Katrin Fischer 2022-12-28 22:00:15 UTC
Created attachment 144882 [details] [review]
Bug 32421: Add collection column to holds to pull

To test:

1. Place some holds
2. Go to Circulation > Holds to pull
3. Notice there is not column to indicate collection ( CCODE )
4. Apply patch and restart services
5. Step 2 again, this time you should see a column for holds to pull
6. Using both the Columns button and via 'Table setting' attempt to hide the column and other columns. Ensure everything is being heiiden correctly.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-12-28 22:00:20 UTC
Created attachment 144883 [details] [review]
Bug 32421: (follow-up) Correct table settings

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi 2023-03-14 12:07:44 UTC
Created attachment 148160 [details] [review]
Bug 32421: Add collection column to holds to pull

To test:

1. Place some holds
2. Go to Circulation > Holds to pull
3. Notice there is not column to indicate collection ( CCODE )
4. Apply patch and restart services
5. Step 2 again, this time you should see a column for holds to pull
6. Using both the Columns button and via 'Table setting' attempt to hide the column and other columns. Ensure everything is being heiiden correctly.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Bug 32421: (follow-up) Correct table settings

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 9 Tomás Cohen Arazi 2023-03-14 12:10:34 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Martin Renvoize 2023-03-20 17:03:12 UTC
Minor enhancement and I've decided we're early enough in the cycle to allow it.. backporting to 22.11.x series.
Comment 11 Martin Renvoize 2023-03-20 17:04:02 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 12 Lucas Gass 2023-04-24 16:41:35 UTC
Enhancement will not be backported to 22.05.x