| Summary: | Reindent holds awaiting pickup template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This tidies up the template used to display the holds awaiting pickup page (Circulation > Holds > Holds awaiting pickup). It also fixes the page so that the circulation sidebar is now shown.
|
Version(s) released in: |
23.05.00,22.11.03
|
| Circulation function: | |||
| Attachments: |
Bug 32482: Reindent holds awaiting pickup template
Bug 32482: (follow-up) Add markup comments Bug 32482: Reindent holds awaiting pickup template Bug 32482: (follow-up) Add markup comments Bug 32482: Reindent holds awaiting pickup template Bug 32482: (follow-up) Add markup comments |
||
|
Description
Owen Leonard
2022-12-16 11:55:24 UTC
Created attachment 144674 [details] [review] Bug 32482: Reindent holds awaiting pickup template This patch reindents the holds awaiting pickup template so that it has consistent indentation. This patch also corrects a markup error that was causing a layout issue. Incorrectly closed <div>s caused the circulation sidebar menu to disappear. To test, apply the patch and test all aspects of the page, including: - Correctly functioning tabs and DataTables - Cancel selected holds waiting - Cancel selected holds waiting past ReservesMaxPickUpDelay - Cancel all holds waiting past ReservesMaxPickUpDelay - Cancel individual holds with cancellation requests (Cancellations of waiting holds via the OPAC. See "Default waiting hold cancellation policy" in Circulation and Fine rules). Created attachment 144675 [details] [review] Bug 32482: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 144709 [details] [review] Bug 32482: Reindent holds awaiting pickup template This patch reindents the holds awaiting pickup template so that it has consistent indentation. This patch also corrects a markup error that was causing a layout issue. Incorrectly closed <div>s caused the circulation sidebar menu to disappear. To test, apply the patch and test all aspects of the page, including: - Correctly functioning tabs and DataTables - Cancel selected holds waiting - Cancel selected holds waiting past ReservesMaxPickUpDelay - Cancel all holds waiting past ReservesMaxPickUpDelay - Cancel individual holds with cancellation requests (Cancellations of waiting holds via the OPAC. See "Default waiting hold cancellation policy" in Circulation and Fine rules). Signed-off-by: David Nind <david@davidnind.com> Created attachment 144710 [details] [review] Bug 32482: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Created attachment 145821 [details] [review] Bug 32482: Reindent holds awaiting pickup template This patch reindents the holds awaiting pickup template so that it has consistent indentation. This patch also corrects a markup error that was causing a layout issue. Incorrectly closed <div>s caused the circulation sidebar menu to disappear. To test, apply the patch and test all aspects of the page, including: - Correctly functioning tabs and DataTables - Cancel selected holds waiting - Cancel selected holds waiting past ReservesMaxPickUpDelay - Cancel all holds waiting past ReservesMaxPickUpDelay - Cancel individual holds with cancellation requests (Cancellations of waiting holds via the OPAC. See "Default waiting hold cancellation policy" in Circulation and Fine rules). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 145822 [details] [review] Bug 32482: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. These fixes have been great but they don't apply well in 22.05.x, no backport. |