Bug 32482 - Reindent holds awaiting pickup template
Summary: Reindent holds awaiting pickup template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-16 11:55 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This tidies up the template used to display the holds awaiting pickup page (Circulation > Holds > Holds awaiting pickup). It also fixes the page so that the circulation sidebar is now shown.
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32482: Reindent holds awaiting pickup template (17.38 KB, patch)
2022-12-16 12:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32482: (follow-up) Add markup comments (5.46 KB, patch)
2022-12-16 12:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32482: Reindent holds awaiting pickup template (17.43 KB, patch)
2022-12-18 07:29 UTC, David Nind
Details | Diff | Splinter Review
Bug 32482: (follow-up) Add markup comments (5.51 KB, patch)
2022-12-18 07:29 UTC, David Nind
Details | Diff | Splinter Review
Bug 32482: Reindent holds awaiting pickup template (17.48 KB, patch)
2023-01-30 22:25 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32482: (follow-up) Add markup comments (5.57 KB, patch)
2023-01-30 22:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-12-16 11:55:24 UTC
I propose to reformat the holds awaiting pickup template (waitingreserves.tt) in the staff interface so that it has consistent spacing and indentation.
Comment 1 Owen Leonard 2022-12-16 12:43:31 UTC
Created attachment 144674 [details] [review]
Bug 32482: Reindent holds awaiting pickup template

This patch reindents the holds awaiting pickup template so that it has
consistent indentation.

This patch also corrects a markup error that was causing a layout issue.
Incorrectly closed <div>s caused the circulation sidebar menu to
disappear.

To test, apply the patch and test all aspects of the page, including:

- Correctly functioning tabs and DataTables
- Cancel selected holds waiting
- Cancel selected holds waiting past ReservesMaxPickUpDelay
- Cancel all holds waiting past ReservesMaxPickUpDelay
- Cancel individual holds with cancellation requests (Cancellations
  of waiting holds via the OPAC. See "Default waiting hold cancellation
  policy" in Circulation and Fine rules).
Comment 2 Owen Leonard 2022-12-16 12:43:35 UTC
Created attachment 144675 [details] [review]
Bug 32482: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 David Nind 2022-12-18 07:29:31 UTC
Created attachment 144709 [details] [review]
Bug 32482: Reindent holds awaiting pickup template

This patch reindents the holds awaiting pickup template so that it has
consistent indentation.

This patch also corrects a markup error that was causing a layout issue.
Incorrectly closed <div>s caused the circulation sidebar menu to
disappear.

To test, apply the patch and test all aspects of the page, including:

- Correctly functioning tabs and DataTables
- Cancel selected holds waiting
- Cancel selected holds waiting past ReservesMaxPickUpDelay
- Cancel all holds waiting past ReservesMaxPickUpDelay
- Cancel individual holds with cancellation requests (Cancellations
  of waiting holds via the OPAC. See "Default waiting hold cancellation
  policy" in Circulation and Fine rules).

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-12-18 07:29:36 UTC
Created attachment 144710 [details] [review]
Bug 32482: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2023-01-30 22:25:35 UTC
Created attachment 145821 [details] [review]
Bug 32482: Reindent holds awaiting pickup template

This patch reindents the holds awaiting pickup template so that it has
consistent indentation.

This patch also corrects a markup error that was causing a layout issue.
Incorrectly closed <div>s caused the circulation sidebar menu to
disappear.

To test, apply the patch and test all aspects of the page, including:

- Correctly functioning tabs and DataTables
- Cancel selected holds waiting
- Cancel selected holds waiting past ReservesMaxPickUpDelay
- Cancel all holds waiting past ReservesMaxPickUpDelay
- Cancel individual holds with cancellation requests (Cancellations
  of waiting holds via the OPAC. See "Default waiting hold cancellation
  policy" in Circulation and Fine rules).

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-01-30 22:25:39 UTC
Created attachment 145822 [details] [review]
Bug 32482: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-01-31 13:23:28 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-01-31 18:11:06 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 9 Lucas Gass 2023-02-03 21:56:29 UTC
These fixes have been great but they don't apply well in 22.05.x, no backport.