| Summary: | Patron search dies on case mismatch of patron category | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Staff interface | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | david, gmcharlt, jonathan.druart, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32706 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33539 |
||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes patron search so that searching by category will work regardless of the patron category code case (upper, lower, and sentence case). Before this, category codes in upper case were expected - where they weren't this caused the search to fail, resulting in no search results.
|
Version(s) released in: |
23.05.00,22.11.02
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 35743 | ||
| Attachments: |
Bug 32517: lowercase category codes to avoid mismatch
Bug 32517: lowercase category codes to avoid mismatch Bug 32517: lowercase category codes to avoid mismatch |
||
Created attachment 144795 [details] [review] Bug 32517: lowercase category codes to avoid mismatch To test: 1 - sudo koha-mysql kohadev 2 - UPDATE borrowers SET categorycode = LCASE(categorycode) 3 - Try to search for patrons: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Search for patrons 6 - Success! Created attachment 144805 [details] [review] Bug 32517: lowercase category codes to avoid mismatch To test: 1 - sudo koha-mysql kohadev 2 - UPDATE borrowers SET categorycode = LCASE(categorycode) 3 - Try to search for patrons: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Search for patrons 6 - Success! Signed-off-by: David Nind <david@davidnind.com> But... should category codes not always be uppercase? In my opinion, yes. But, we have never enforced that. SQL is generally not case sensitive, unless you ask it to be - this is a consequence of Javascript. I think we should err on the side of codes needing to be unique, but not case sensitive Just noting that this issue (I think) was raised on the general mailing list: https://lists.katipo.co.nz/pipermail/koha/2023-January/058867.html Has a slightly different error message, but seems related to case sensitivity with patron category values. (In reply to Nick Clemens from comment #4) > In my opinion, yes. But, we have never enforced that. Not sure when that changed. But currently you cannot save a lowercase one in the interface. Created attachment 145256 [details] [review] Bug 32517: lowercase category codes to avoid mismatch To test: 1 - sudo koha-mysql kohadev 2 - UPDATE borrowers SET categorycode = LCASE(categorycode) 3 - Try to search for patrons: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Search for patrons 6 - Success! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Confirm that this fixes the problem introduced by sql changing the category to lowercase. This is not possible now in the interface. So it is a bit arguable patch. But I dont object. Note that you could go the other way and add a dbrev that makes all categorycodes uppercase in borrowers for example. Marking it as major seems overkill btw. (In reply to Marcel de Rooy from comment #8) > Marking it as major seems overkill btw. A few bad patrons could break the patron search at large - this is a huge impact for libraries that may have a hard time diagnosing the issue. I am still curious on how they ended up there in the first place. As long as I can remember you can't add lower case ones... could this be related to API/patron import/SQL based migrations? I am a little worried that if we fix this bug, it might just be a band aid in one spot while in other places we'll still see issues. (In reply to Katrin Fischer from comment #10) > I am still curious on how they ended up there in the first place. As long as > I can remember you can't add lower case ones... could this be related to > API/patron import/SQL based migrations? > > I am a little worried that if we fix this bug, it might just be a band aid > in one spot while in other places we'll still see issues. Yes, we believe related to API/patron imports, or just very old data Nice work everyone! Pushed to 23.05.x for the next release Nice work, thanks everyone! Pushed to 22.11.x for the next release. We need to fix the root of the problem, during the import. We provide a script to catch this problem. We should not deal with that in the template, that's silly. (In reply to Jonathan Druart from comment #14) > We need to fix the root of the problem, during the import. We provide a > script to catch this problem. We should not deal with that in the template, > that's silly. Still valid, this needs to be fixed properly. I am now writing workarounds in code that is trying to be generic for this specific "category" search. |
We load the categories in JS for transforming category codes to names, however, this introduces case sensitivity To recreate: 1 - sudo koha-mysql kohadev 2 - UPDATE borrowers SET categorycode = LCASE(categorycode) 3 - Try to search for patrons: Uncaught TypeError: categories_map[data] is undefined