Bug 35743 - The "category" filter is not selected in the column filter dropdown
Summary: The "category" filter is not selected in the column filter dropdown
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 32517
Blocks: 35329
  Show dependency tree / graph
 
Reported: 2024-01-09 13:49 UTC by Jonathan Druart
Modified: 2024-12-05 15:51 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03
Circulation function:

Attachments
Bug 35743: Fix patron's category selection in the column filter (1.63 KB, patch)
2024-01-09 14:01 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 35743: Fix patron's category selection in the column filter (1.69 KB, patch)
2024-01-09 16:45 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 35743: Fix patron's category selection in the column filter (1.76 KB, patch)
2024-01-17 11:04 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-01-09 13:49:28 UTC 
When a patron search is triggered and a category has been selected, the dropdown filter on top of the column does not contain the selected category.
Comment 1 Jonathan Druart 2024-01-09 14:01:29 UTC 
Created attachment 160695 [details] [review]
Bug 35743: Fix patron's category selection in the column filter

The "category" filter is not selected in the column filter dropdown.

Test plan:
0. Do not apply this patch
1. Search for patron, select a patron's category
=> Notice that the "Category" column has a column filter, but no option
   is selected
2. Apply the patch
3. Repeat 1
=> The "Category" column has the option you selected in the filter block.
Comment 2 Owen Leonard 2024-01-09 16:45:58 UTC 
Created attachment 160711 [details] [review]
Bug 35743: Fix patron's category selection in the column filter

The "category" filter is not selected in the column filter dropdown.

Test plan:
0. Do not apply this patch
1. Search for patron, select a patron's category
   => Notice that the "Category" column has a column filter, but no
      option is selected
2. Apply the patch
3. Repeat 1
   => The "Category" column has the option you selected in the filter
      block.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2024-01-17 11:04:08 UTC 
Created attachment 161092 [details] [review]
Bug 35743: Fix patron's category selection in the column filter

The "category" filter is not selected in the column filter dropdown.

Test plan:
0. Do not apply this patch
1. Search for patron, select a patron's category
   => Notice that the "Category" column has a column filter, but no
      option is selected
2. Apply the patch
3. Repeat 1
   => The "Category" column has the option you selected in the filter
      block.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2024-01-17 11:04:44 UTC 
Trivial fix working as expected.. Passing QA
Comment 5 Katrin Fischer 2024-01-29 11:29:05 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-02-01 14:47:04 UTC 
Pushed to 23.11.x for 23.11.03