Summary: | BorrowerUnwantedField syspref should not include borrowers.flags | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | System Administration | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, m.de.rooy, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.02
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 32544 | ||
Attachments: |
Bug 32535: Exclude flags from BorrowerUnwantedField system preference
Bug 32535: Exclude flags from BorrowerUnwantedField system preference Bug 32535: Exclude flags from BorrowerUnwantedField system preference |
Description
Andrew Fuerste-Henry
2022-12-27 18:58:19 UTC
Created attachment 144871 [details] [review] Bug 32535: Exclude flags from BorrowerUnwantedField system preference The system preference BorrowerUnwantedField includes a checkbox for "System permissions (flags)." Checking it has no apparent effect; one is still able to edit patron permissions with the box checked. This patch excludes the field from the selectable fields. To test: * Search for the BorrowerUnwantedField system prefernce * Verify that you can check/uncheck System permissions (flags) * Verify it doesn't have any effect, as permissions are not set from the patron edit form, but separately * Apply patch * Verify you no longer can check/uncheck the field in the system preference Created attachment 144873 [details] [review] Bug 32535: Exclude flags from BorrowerUnwantedField system preference The system preference BorrowerUnwantedField includes a checkbox for "System permissions (flags)." Checking it has no apparent effect; one is still able to edit patron permissions with the box checked. This patch excludes the field from the selectable fields. To test: * Search for the BorrowerUnwantedField system prefernce * Verify that you can check/uncheck System permissions (flags) * Verify it doesn't have any effect, as permissions are not set from the patron edit form, but separately * Apply patch * Verify you no longer can check/uncheck the field in the system preference Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Thx, Andrew! Don't thank me yet! In signing off on this one I thought to look at all the other Unwanted and Mandatory field sysprefs and they all include flags as well. Filed bug 32544. (In reply to Andrew Fuerste-Henry from comment #4) > Don't thank me yet! In signing off on this one I thought to look at all the > other Unwanted and Mandatory field sysprefs and they all include flags as > well. Filed bug 32544. Maybe you should think about joining the QA team ;) Created attachment 145261 [details] [review] Bug 32535: Exclude flags from BorrowerUnwantedField system preference The system preference BorrowerUnwantedField includes a checkbox for "System permissions (flags)." Checking it has no apparent effect; one is still able to edit patron permissions with the box checked. This patch excludes the field from the selectable fields. To test: * Search for the BorrowerUnwantedField system prefernce * Verify that you can check/uncheck System permissions (flags) * Verify it doesn't have any effect, as permissions are not set from the patron edit form, but separately * Apply patch * Verify you no longer can check/uncheck the field in the system preference Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to 23.05.x for the next release Nice work, thanks everyone! Pushed to 22.11.x for the next release. |