Bug 32545

Summary: For naming consistency, PatronSelfModificationMandatoryField should be PatronSelfModificationBorrowerMandatoryField
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: System AdministrationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Andrew Fuerste-Henry 2022-12-28 21:41:57 UTC
The syspref PatronSelfModificationMandatoryField should be PatronSelfModificationBorrowerMandatoryField

It's part of a set of sysprefs with  an existing naming convention. For the staff interface, we have BorrowerUnwantedField and BorrowerManadatoryField. We prepend "PatronSelfRegistration" onto those names for PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField. We prepend "PatronSelfModification" for PatronSelfModificationBorrowerUnwantedField. 

Making PatronSelfModificationMandatoryField break the established convention causes confusion (even if PatronSelfModificationBorrowerMandatoryField is goofily long).