Bug 32545 - For naming consistency, PatronSelfModificationMandatoryField should be PatronSelfModificationBorrowerMandatoryField
Summary: For naming consistency, PatronSelfModificationMandatoryField should be Patron...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-28 21:41 UTC by Andrew Fuerste-Henry
Modified: 2022-12-28 21:41 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2022-12-28 21:41:57 UTC
The syspref PatronSelfModificationMandatoryField should be PatronSelfModificationBorrowerMandatoryField

It's part of a set of sysprefs with  an existing naming convention. For the staff interface, we have BorrowerUnwantedField and BorrowerManadatoryField. We prepend "PatronSelfRegistration" onto those names for PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField. We prepend "PatronSelfModification" for PatronSelfModificationBorrowerUnwantedField. 

Making PatronSelfModificationMandatoryField break the established convention causes confusion (even if PatronSelfModificationBorrowerMandatoryField is goofily long).