Description
Martin Renvoize (ashimema)
2023-01-06 15:12:17 UTC
Created attachment 145085 [details] [review] Bug 32576: Move page-section outside of table include This patch drops the superflous div from the ill-list-table include and instead opts to wrap calls to it with a more appropriately positioned div instead. Created attachment 145086 [details] [review] Bug 32576: Replace panels with page-sections Almost missed this one - looks nice! We have a 'competing' patch on bug 32564, but I think I prefer the page-sections. Did you forget to set Needs Signoff or was there something missing here still? Created attachment 145342 [details] [review] Bug 32576: Move page-section outside of table include This patch drops the superflous div from the ill-list-table include and instead opts to wrap calls to it with a more appropriately positioned div instead. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 145343 [details] [review] Bug 32576: Replace panels with page-sections Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> *** Bug 32564 has been marked as a duplicate of this bug. *** Created attachment 147430 [details] [review] Bug 32576: Move page-section outside of table include This patch drops the superflous div from the ill-list-table include and instead opts to wrap calls to it with a more appropriately positioned div instead. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 147431 [details] [review] Bug 32576: Replace panels with page-sections This patch replaces the bootstrap panels with the more modern koha page-section cards layout. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased, thanks for taking a look Jonathan. Created attachment 147489 [details] [review] Bug 32576: Move page-section outside of table include This patch drops the superflous div from the ill-list-table include and instead opts to wrap calls to it with a more appropriately positioned div instead. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147490 [details] [review] Bug 32576: Replace panels with page-sections This patch replaces the bootstrap panels with the more modern koha page-section cards layout. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x |