Bug 32564 - ILL request detail page has some style issues with new staff interface design
Summary: ILL request detail page has some style issues with new staff interface design
Status: RESOLVED DUPLICATE of bug 32576
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency tree / graph
 
Reported: 2023-01-04 15:28 UTC by Katrin Fischer
Modified: 2023-01-31 14:46 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 32654: Update ILL template markup to conform to Bootstrap panels (21.59 KB, patch)
2023-01-04 19:57 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 32564: Update ILL template markup to conform to Bootstrap panels (21.64 KB, patch)
2023-01-05 12:10 UTC, David Nind 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-01-04 15:28:33 UTC 
I see some stranger style issues in the ILL request detail page with the new staff interface design. To name some:

* The page sections have alight blue background and when you hover over the section, the background turns light green
* There are light green borders around the elements
* There is a line below the section headings
Comment 1 Owen Leonard 2023-01-04 19:57:44 UTC 
Created attachment 145046 [details] [review]
Bug 32654: Update ILL template markup to conform to Bootstrap panels

The ILL request detail template uses Bootstrap panel markup that
isn't quite correct. This patch changes the markup around the
details and comments panels so that they look correct.

To test you must have ILL enabled and have at least one request
to view.

- Apply the patch and go to ILL requests -> Manage request
- The page should display with the "Request details" panel
  expanded by default.
- Expanding and collapsing the "Request details" and "Comments"
  panels should work correctly.
Comment 2 David Nind 2023-01-05 12:10:49 UTC 
Created attachment 145057 [details] [review]
Bug 32564: Update ILL template markup to conform to Bootstrap panels

The ILL request detail template uses Bootstrap panel markup that
isn't quite correct. This patch changes the markup around the
details and comments panels so that they look correct.

To test you must have ILL enabled and have at least one request
to view.

- Apply the patch and go to ILL requests -> Manage request
- The page should display with the "Request details" panel
  expanded by default.
- Expanding and collapsing the "Request details" and "Comments"
  panels should work correctly.

https://bugs.koha-community.org/show_bug.cgi?id=32564

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-01-05 12:13:35 UTC 
Testing notes (using KTD):

1. I amended the commit message to fix the bug title (should be Bug 32564: ....)/

2. Enabled the FreeForm backend using the instructions at https://wiki.koha-community.org/wiki/ILL_backends
Comment 4 Katrin Fischer 2023-01-16 20:24:44 UTC 
I am very sorry I didn't realize this sooner, but this is now kind of a duplicate of bug 32576. And it gets 'worse': Bug 32576 converts the panels to page sections which I like a little better - Would you mind having a look if you agree?
Comment 5 Martin Renvoize (ashimema) 2023-01-31 14:46:27 UTC 

*** This bug has been marked as a duplicate of bug 32576 ***