| Summary: | Filters on top of 'Items with no checkouts' report are untranslatable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | I18N/L10N | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize <martin.renvoize> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | f.demians, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
| Circulation function: | |||
| Bug Depends on: | 32589 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 32588: Make filters on 'items with no checkouts' report translatable
Bug 32588: Make filters on 'items with no checkouts' report translatable Bug 32588: Make filters on 'items with no checkouts' report translatable Bug 32588: (QA follow-up) Add missing filter |
||
|
Description
Katrin Fischer
2023-01-07 00:40:53 UTC
Created attachment 145124 [details] [review] Bug 32588: Make filters on 'items with no checkouts' report translatable This makes the filters on top of the 'items with no checkouts' report translatable. The descriptions of the filters used the wrong terms and were also pulled from the .pl file, making them untranslatable. To test: * Without patch: Run the 'items with no checkouts' report with various settigs. * Verify, that the display on top doesn't use standard terminology Doc type = item type, Branch = library * Apply patch * Verify display is improved and standard terminology is used If you know how to, you can also confirm strings show up nicely in translations: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation Created attachment 145130 [details] [review] Bug 32588: Make filters on 'items with no checkouts' report translatable This makes the filters on top of the 'items with no checkouts' report translatable. The descriptions of the filters used the wrong terms and were also pulled from the .pl file, making them untranslatable. To test: * Without patch: Run the 'items with no checkouts' report with various settigs. * Verify, that the display on top doesn't use standard terminology Doc type = item type, Branch = library * Apply patch * Verify display is improved and standard terminology is used If you know how to, you can also confirm strings show up nicely in translations: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Thank you, Frédéric! Created attachment 145861 [details] [review] Bug 32588: Make filters on 'items with no checkouts' report translatable This makes the filters on top of the 'items with no checkouts' report translatable. The descriptions of the filters used the wrong terms and were also pulled from the .pl file, making them untranslatable. To test: * Without patch: Run the 'items with no checkouts' report with various settigs. * Verify, that the display on top doesn't use standard terminology Doc type = item type, Branch = library * Apply patch * Verify display is improved and standard terminology is used If you know how to, you can also confirm strings show up nicely in translations: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All working as expected, Thanks Katrin. Passing QA Created attachment 145871 [details] [review] Bug 32588: (QA follow-up) Add missing filter Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Missing dependencies for 22.05.x, no backport. |