Summary: | Improve headings on result tables for 'checkouts with no items' report | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Reports | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | f.demians, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
Circulation function: | |||
Bug Depends on: | 32587 | ||
Bug Blocks: | 32588 | ||
Attachments: |
Bug 32589: Improve headings on result tables for 'Items with no checkouts'
Bug 32589: Improve headings on result tables for 'Items with no checkouts' Bug 32589: Improve headings on result tables for 'Items with no checkouts' |
Description
Katrin Fischer
2023-01-07 00:45:54 UTC
Created attachment 145123 [details] [review] Bug 32589: Improve headings on result tables for 'Items with no checkouts' When no filter was selected on the search form, the heading on the results table showed as NULL. When library or item type were selected the codes instead of the descriptions showed. To test: * Without patch: * Run the 'items with no checkouts' report with different settings for 'By:'. Verify the headings on the tables are not nice. * Apply patch * Rerun reports * Headings should be "Ungrouped, item type or library descriptions * Summary table also shows item type and library descriptions Created attachment 145129 [details] [review] Bug 32589: Improve headings on result tables for 'Items with no checkouts' When no filter was selected on the search form, the heading on the results table showed as NULL. When library or item type were selected the codes instead of the descriptions showed. To test: * Without patch: * Run the 'items with no checkouts' report with different settings for 'By:'. Verify the headings on the tables are not nice. * Apply patch * Rerun reports * Headings should be "Ungrouped, item type or library descriptions * Summary table also shows item type and library descriptions Signed-off-by: Frédéric Demians <f.demians@tamil.fr> → OK. Would be nice to have decoding also in 'Filtered on' top section Forget my comment about decoding top section: solved by bug 32588 (In reply to Frédéric Demians from comment #3) > Forget my comment about decoding top section: solved by bug 32588 Yes, I tried to break it up into smaller steps - thx for working through the tree :) Created attachment 145860 [details] [review] Bug 32589: Improve headings on result tables for 'Items with no checkouts' When no filter was selected on the search form, the heading on the results table showed as NULL. When library or item type were selected the codes instead of the descriptions showed. To test: * Without patch: * Run the 'items with no checkouts' report with different settings for 'By:'. Verify the headings on the tables are not nice. * Apply patch * Rerun reports * Headings should be "Ungrouped, item type or library descriptions * Summary table also shows item type and library descriptions Signed-off-by: Frédéric Demians <f.demians@tamil.fr> → OK. Would be nice to have decoding also in 'Filtered on' top section Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Another nice little improvement, Passing QA Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Missing dependencies for 22.05.x, no backport |