Summary: | Add 'page-section' to various administration pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, lucas, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
Circulation function: | |||
Bug Depends on: | 30952 | ||
Bug Blocks: | 31757 | ||
Attachments: |
Bug 32618: Add 'page-section' to various administration pages
Bug 32618: Add 'page-section' to various administration pages Bug 32618: Add 'page-section' to various administration pages |
Description
Owen Leonard
2023-01-12 17:59:49 UTC
Created attachment 145242 [details] [review] Bug 32618: Add 'page-section' to various administration pages This patch adds a "page-section" container div around the main section of administration pages which lack it. The SMS providers page required a small change to the associated JavaScript in order to target the right container, so you may need to clear your browser cache to get the correct behavior. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Contracts - Administration -> Budgets -> Budget details -> Planning - Administration -> Circulation desks - Administration -> OAI sets configuration -> Define mappings - Administration -> System preferences -> Search for 'OverDriveAuthName' -> OverDrive library authnames table - Administration -> SMS cellular providers - Confirm that the "Edit" buttons work correctly to show and hide the right content. Created attachment 145245 [details] [review] Bug 32618: Add 'page-section' to various administration pages This patch adds a "page-section" container div around the main section of administration pages which lack it. The SMS providers page required a small change to the associated JavaScript in order to target the right container, so you may need to clear your browser cache to get the correct behavior. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Contracts - Administration -> Budgets -> Budget details -> Planning - Administration -> Circulation desks - Administration -> OAI sets configuration -> Define mappings - Administration -> System preferences -> Search for 'OverDriveAuthName' -> OverDrive library authnames table - Administration -> SMS cellular providers - Confirm that the "Edit" buttons work correctly to show and hide the right content. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. For circulation desks, enable UseCirculationDesks. 2. For SMS cellular providers, enable SMSSendDriver (I used Email). 1) The 'new contract' form has the save button inside the page-section. Should it not be outside? 2) aqplan.tt: Save button here is also inside the page-section. 3) oai_set_mapping.tt: Same as above. Have we established a style guideline for save buttons? I know we're inconsistent, but I don't know that we have set down a rule yet. I have filed this bug to deal with save button consistency: Bug 32744: [OMNIBUS] Standardize structure around action fieldsets (In reply to Owen Leonard from comment #6) > I have filed this bug to deal with save button consistency: > > > Bug 32744: [OMNIBUS] Standardize structure around action fieldset Agreed, let's get this in and then work on making things (even more) consistent. Created attachment 145829 [details] [review] Bug 32618: Add 'page-section' to various administration pages This patch adds a "page-section" container div around the main section of administration pages which lack it. The SMS providers page required a small change to the associated JavaScript in order to target the right container, so you may need to clear your browser cache to get the correct behavior. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Contracts - Administration -> Budgets -> Budget details -> Planning - Administration -> Circulation desks - Administration -> OAI sets configuration -> Define mappings - Administration -> System preferences -> Search for 'OverDriveAuthName' -> OverDrive library authnames table - Administration -> SMS cellular providers - Confirm that the "Edit" buttons work correctly to show and hide the right content. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Missing dependencies for 22.05.x, no backport. |