Bug 32618 - Add 'page-section' to various administration pages
Summary: Add 'page-section' to various administration pages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2023-01-12 17:59 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32618: Add 'page-section' to various administration pages (41.23 KB, patch)
2023-01-12 18:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32618: Add 'page-section' to various administration pages (41.28 KB, patch)
2023-01-12 20:31 UTC, David Nind
Details | Diff | Splinter Review
Bug 32618: Add 'page-section' to various administration pages (41.33 KB, patch)
2023-01-30 22:56 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-01-12 17:59:49 UTC
Several administration templates need to have main content wrapped in a "page-section" container.

- admin/aqcontract.tt
- admin/aqplan.tt
- admin/desks.tt
- admin/oai_set_mappings.tt
- admin/overdrive.tt
- admin/sms_providers.tt
Comment 1 Owen Leonard 2023-01-12 18:19:57 UTC Comment hidden (obsolete)
Comment 2 David Nind 2023-01-12 20:31:10 UTC
Created attachment 145245 [details] [review]
Bug 32618: Add 'page-section' to various administration pages

This patch adds a "page-section" container div around the main section
of administration pages which lack it.

The SMS providers page required a small change to the associated
JavaScript in order to target the right container, so you may need to
clear your browser cache to get the correct behavior.

This patch contains indentation changes, so please ignore whitespace
when looking at the diff.

To test, apply the patch and view the following pages to confirm that
the main content is contained in a white box:

 - Acquisitions -> Vendor -> Contracts
 - Administration -> Budgets -> Budget details -> Planning
 - Administration -> Circulation desks
 - Administration -> OAI sets configuration -> Define mappings
 - Administration -> System preferences -> Search for
   'OverDriveAuthName' -> OverDrive library authnames table
 - Administration -> SMS cellular providers
   - Confirm that the "Edit" buttons work correctly to show and hide the
     right content.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-01-12 20:33:02 UTC
Testing notes (using KTD):

1. For circulation desks, enable UseCirculationDesks.

2. For SMS cellular providers, enable SMSSendDriver (I used Email).
Comment 4 Katrin Fischer 2023-01-16 19:52:52 UTC
1) The 'new contract' form has the save button inside the page-section. Should it not be outside?

2) aqplan.tt: Save button here is also inside the page-section.

3) oai_set_mapping.tt: Same as above.
Comment 5 Owen Leonard 2023-01-18 16:29:16 UTC
Have we established a style guideline for save buttons? I know we're inconsistent, but I don't know that we have set down a rule yet.
Comment 6 Owen Leonard 2023-01-30 14:45:39 UTC
I have filed this bug to deal with save button consistency:


Bug 32744: [OMNIBUS] Standardize structure around action fieldsets
Comment 7 Katrin Fischer 2023-01-30 22:55:00 UTC
(In reply to Owen Leonard from comment #6)
> I have filed this bug to deal with save button consistency:
> 
> 
> Bug 32744: [OMNIBUS] Standardize structure around action fieldset

Agreed, let's get this in and then work on making things (even more) consistent.
Comment 8 Katrin Fischer 2023-01-30 22:56:00 UTC
Created attachment 145829 [details] [review]
Bug 32618: Add 'page-section' to various administration pages

This patch adds a "page-section" container div around the main section
of administration pages which lack it.

The SMS providers page required a small change to the associated
JavaScript in order to target the right container, so you may need to
clear your browser cache to get the correct behavior.

This patch contains indentation changes, so please ignore whitespace
when looking at the diff.

To test, apply the patch and view the following pages to confirm that
the main content is contained in a white box:

 - Acquisitions -> Vendor -> Contracts
 - Administration -> Budgets -> Budget details -> Planning
 - Administration -> Circulation desks
 - Administration -> OAI sets configuration -> Define mappings
 - Administration -> System preferences -> Search for
   'OverDriveAuthName' -> OverDrive library authnames table
 - Administration -> SMS cellular providers
   - Confirm that the "Edit" buttons work correctly to show and hide the
     right content.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi 2023-01-31 12:42:17 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Jacob O'Mara 2023-01-31 17:47:08 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 11 Lucas Gass 2023-02-03 21:46:04 UTC
Missing dependencies for 22.05.x, no backport.