Bug 32670

Summary: t/db_dependent/Circulation.t is failing on 22.05_U20
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Chris Cormack <chris>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: lucas
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 25551    

Description Jonathan Druart 2023-01-18 08:17:06 UTC
22:56:03 koha_1       |     #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore'
22:56:03 koha_1       |     #   at t/db_dependent/Circulation.t line 5440.
22:56:03 koha_1       |     #          got: '2023-01-17T21:50:57'
22:56:03 koha_1       |     #     expected: '2023-01-31T00:00:00'
22:56:03 koha_1       | 
22:56:03 koha_1       |     #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore'
22:56:03 koha_1       |     #   at t/db_dependent/Circulation.t line 5446.
22:56:03 koha_1       |     #          got: '2023-01-17T21:50:57'
22:56:03 koha_1       |     #     expected: '2023-01-31T23:59:00'
22:56:03 koha_1       |     # Looks like you failed 2 tests of 5.
22:56:03 koha_1       | 
22:56:03 koha_1       | #   Failed test 'GetSoonestRenewDate tests'
22:56:03 koha_1       | #   at t/db_dependent/Circulation.t line 5451.
22:56:03 koha_1       | # Looks like you failed 1 test of 60.
22:56:03 koha_1       | [21:52:03] t/db_dependent/Circulation.t

Koha_22.05_U20/130
Comment 1 Jonathan Druart 2023-01-18 16:10:41 UTC
I recreated locally, 22.05 and focal, after 100 runs

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' 
    #   at t/db_dependent/Circulation.t line 341.                                                         
    #          got: '2023-01-18T15:42:43'                                                                 
    #     expected: '2023-02-01T00:00:00'                                                                                                                                                                            
                                                                                                          
    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' 
    #   at t/db_dependent/Circulation.t line 347.                                                         
    #          got: '2023-01-18T15:42:43'                                                                 
    #     expected: '2023-02-01T23:59:00'                                                                 
    # Looks like you failed 2 tests of 5.                                                                 
                                                                                                          
#   Failed test 'GetSoonestRenewDate tests'                                                               
#   at t/db_dependent/Circulation.t line 352.

Line numbers differ as I removed all the tests before.
Comment 2 Jonathan Druart 2023-01-18 16:11:13 UTC
    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 341.
    #          got: '2023-01-18T16:10:12'
    #     expected: '2023-02-01T00:00:00'

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 347.
    #          got: '2023-01-18T16:10:12'
    #     expected: '2023-02-01T23:59:00'
Comment 3 Jonathan Druart 2023-01-18 16:12:03 UTC
(In reply to Jonathan Druart from comment #2)
>     #          got: '2023-01-18T16:10:12'

which is $now, so we hit return $now in GetSoonestRenewDate
Comment 4 Jonathan Druart 2023-01-18 16:26:39 UTC

*** This bug has been marked as a duplicate of bug 32269 ***