21:28:55 koha_1 | # Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' 21:28:55 koha_1 | # at t/db_dependent/Circulation.t line 5683. 21:28:55 koha_1 | # got: '2022-11-17T20:25:30' 21:28:55 koha_1 | # expected: '2022-12-01T00:00:00' 21:28:55 koha_1 | 21:28:55 koha_1 | # Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' 21:28:55 koha_1 | # at t/db_dependent/Circulation.t line 5689. 21:28:55 koha_1 | # got: '2022-11-17T20:25:30' 21:28:55 koha_1 | # expected: '2022-12-01T23:59:00' 21:28:55 koha_1 | # Looks like you failed 2 tests of 5.
Created attachment 144067 [details] [review] Bug 32269: Prevent Circulation.t to fail randomly Highlighted by Bug 32030: fix test builder for boolean # Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' # at t/db_dependent/Circulation.t line 343. # got: '2022-11-18T14:16:12' # expected: '2022-12-02T00:00:00' # Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' # at t/db_dependent/Circulation.t line 349. # got: '2022-11-18T14:16:12' # expected: '2022-12-02T23:59:00' # Looks like you failed 2 tests of 5 We were reaching return $now
Created attachment 144090 [details] [review] Bug 32269: Prevent Circulation.t to fail randomly Highlighted by Bug 32030: fix test builder for boolean # Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' # at t/db_dependent/Circulation.t line 343. # got: '2022-11-18T14:16:12' # expected: '2022-12-02T00:00:00' # Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' # at t/db_dependent/Circulation.t line 349. # got: '2022-11-18T14:16:12' # expected: '2022-12-02T23:59:00' # Looks like you failed 2 tests of 5 We were reaching return $now Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 144192 [details] [review] Bug 32269: Prevent Circulation.t to fail randomly Highlighted by Bug 32030: fix test builder for boolean # Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' # at t/db_dependent/Circulation.t line 343. # got: '2022-11-18T14:16:12' # expected: '2022-12-02T00:00:00' # Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' # at t/db_dependent/Circulation.t line 349. # got: '2022-11-18T14:16:12' # expected: '2022-12-02T23:59:00' # Looks like you failed 2 tests of 5 We were reaching return $now Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 22.11. Nice work everyone, thanks!
Can you please backport random failure fixes?
*** Bug 32674 has been marked as a duplicate of this bug. ***
*** Bug 32670 has been marked as a duplicate of this bug. ***