Summary: | Display incorrect when matching authority records during import | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Tools | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | alexis, andrew, arthur.suzuki, jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04,22.05.11
|
|
Circulation function: | |||
Bug Depends on: | 22785 | ||
Bug Blocks: | |||
Attachments: |
Bug 32685: Correct authority match display on import
Bug 32685: Correct authority match display on import Bug 32685: Correct authority match display on import |
Description
Nick Clemens (kidclamp)
2023-01-19 20:45:20 UTC
Created attachment 145495 [details] [review] Bug 32685: Correct authority match display on import Bug 22785 updated the import records table, but mixed javascript variables and template toolkit, this means all matches are treated as biblios To test: 1 - Export some authority records form Koha 2 - Create a matching rule based on 'Local-number' and field 001 3 - Stage the records for import using above rule 4 - Note the match links point to authorities, but the citations point to biblios 5 - Apply patch 6 - Reload the page 7 - Confirm the links have the correct text Created attachment 145546 [details] [review] Bug 32685: Correct authority match display on import Bug 22785 updated the import records table, but mixed javascript variables and template toolkit, this means all matches are treated as biblios To test: 1 - Export some authority records form Koha 2 - Create a matching rule based on 'Local-number' and field 001 3 - Stage the records for import using above rule 4 - Note the match links point to authorities, but the citations point to biblios 5 - Apply patch 6 - Reload the page 7 - Confirm the links have the correct text Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 147210 [details] [review] Bug 32685: Correct authority match display on import Bug 22785 updated the import records table, but mixed javascript variables and template toolkit, this means all matches are treated as biblios To test: 1 - Export some authority records form Koha 2 - Create a matching rule based on 'Local-number' and field 001 3 - Stage the records for import using above rule 4 - Note the match links point to authorities, but the citations point to biblios 5 - Apply patch 6 - Reload the page 7 - Confirm the links have the correct text Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I didn't test, trusting author and tester. The change makes sense. Pushed to master for 23.05. Nice work everyone, thanks! *** Bug 32579 has been marked as a duplicate of this bug. *** Nice work everyone! Pushed to stable for 22.11.x Backported to 22.05.x for upcoming 22.05.11 dependency not met, won't backport to 21.11 |