| Summary: | Standardize structure around action fieldsets in serials | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | lucas, martin.renvoize, matt.blenkinsop, testopia, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05
|
|
| Circulation function: | |||
| Bug Depends on: | 32746 | ||
| Bug Blocks: | 32744 | ||
| Attachments: |
Bug 32771: Standardize structure around action fieldsets in serials
Bug 32771: Standardize structure around action fieldsets in serials Bug 32771: Standardize structure around action fieldsets in serials Bug 32771: Standardize structure around action fieldsets in serials Bug 32771: Standardize structure around action fieldsets in serials |
||
|
Description
Owen Leonard
2023-01-31 18:58:25 UTC
Created attachment 145930 [details] [review] Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. I think there is another fieldset that has been missed as the sidebar on serials-search is still inside the main form fieldset - see lines 434-440 in serials-search.tt Does this need amending as well or is this not subject to the same standardized structure? Created attachment 146038 [details] [review] Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. Created attachment 146449 [details] [review] Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. Signed-off-by: David Nind <david@davidnind.com> Created attachment 147362 [details] [review] Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 148514 [details] [review] Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Enhancement will not be backported to 22.05.x |